eregon / app2engine

Ease the conversion of a Rails 3 app in an Engine
http://github.com/eregon/app2engine
MIT License
32 stars 0 forks source link

Global access to Rake DSL methods is deprecated. #2

Closed mdkarp closed 11 years ago

mdkarp commented 11 years ago

Rake tasks error out.

WARNING: Global access to Rake DSL methods is deprecated. Please include ... Rake::DSL into classes and modules which use the Rake DSL methods. WARNING: DSL method App2Engine::Rake::Tasks#namespace called at /Users/mdkarp/.rvm/gems/ruby-1.9.3-p194/gems/app2engine-0.0.5/lib/app2engine/rake/tasks.rb:26:in initialize' WARNING: DSL method App2Engine::Rake::Tasks#task called at /Users/mdkarp/.rvm/gems/ruby-1.9.3-p194/gems/app2engine-0.0.5/lib/app2engine/rake/convert_tasks.rb:6:inconvert_tasks' WARNING: DSL method App2Engine::Rake::Tasks#namespace called at /Users/mdkarp/.rvm/gems/ruby-1.9.3-p194/gems/app2engine-0.0.5/lib/app2engine/rake/convert_tasks.rb:13:in convert_tasks' WARNING: DSL method App2Engine::Rake::Tasks#desc called at /Users/mdkarp/.rvm/gems/ruby-1.9.3-p194/gems/app2engine-0.0.5/lib/app2engine/rake/tasks.rb:35:indefine_task' WARNING: DSL method App2Engine::Rake::Tasks#task called at /Users/mdkarp/.rvm/gems/ruby-1.9.3-p194/gems/app2engine-0.0.5/lib/app2engine/rake/tasks.rb:36:in define_task' WARNING: DSL method App2Engine::Rake::Tasks#desc called at /Users/mdkarp/.rvm/gems/ruby-1.9.3-p194/gems/app2engine-0.0.5/lib/app2engine/rake/tasks.rb:35:indefine_task' WARNING: DSL method App2Engine::Rake::Tasks#task called at /Users/mdkarp/.rvm/gems/ruby-1.9.3-p194/gems/app2engine-0.0.5/lib/app2engine/rake/tasks.rb:36:in define_task' WARNING: DSL method App2Engine::Rake::Tasks#desc called at /Users/mdkarp/.rvm/gems/ruby-1.9.3-p194/gems/app2engine-0.0.5/lib/app2engine/rake/tasks.rb:35:indefine_task' WARNING: DSL method App2Engine::Rake::Tasks#task called at /Users/mdkarp/.rvm/gems/ruby-1.9.3-p194/gems/app2engine-0.0.5/lib/app2engine/rake/tasks.rb:36:in define_task' WARNING: DSL method App2Engine::Rake::Tasks#desc called at /Users/mdkarp/.rvm/gems/ruby-1.9.3-p194/gems/app2engine-0.0.5/lib/app2engine/rake/tasks.rb:35:indefine_task' WARNING: DSL method App2Engine::Rake::Tasks#task called at /Users/mdkarp/.rvm/gems/ruby-1.9.3-p194/gems/app2engine-0.0.5/lib/app2engine/rake/tasks.rb:36:in define_task' WARNING: DSL method App2Engine::Rake::Tasks#desc called at /Users/mdkarp/.rvm/gems/ruby-1.9.3-p194/gems/app2engine-0.0.5/lib/app2engine/rake/tasks.rb:35:indefine_task' WARNING: DSL method App2Engine::Rake::Tasks#task called at /Users/mdkarp/.rvm/gems/ruby-1.9.3-p194/gems/app2engine-0.0.5/lib/app2engine/rake/tasks.rb:36:in define_task' WARNING: DSL method App2Engine::Rake::Tasks#task called at /Users/mdkarp/.rvm/gems/ruby-1.9.3-p194/gems/app2engine-0.0.5/lib/app2engine/rake/extra_tasks.rb:15:inextra_tasks' WARNING: DSL method App2Engine::Rake::Tasks#namespace called at /Users/mdkarp/.rvm/gems/ruby-1.9.3-p194/gems/app2engine-0.0.5/lib/app2engine/rake/extra_tasks.rb:16:in extra_tasks' WARNING: DSL method App2Engine::Rake::Tasks#desc called at /Users/mdkarp/.rvm/gems/ruby-1.9.3-p194/gems/app2engine-0.0.5/lib/app2engine/rake/tasks.rb:35:indefine_task' WARNING: DSL method App2Engine::Rake::Tasks#task called at /Users/mdkarp/.rvm/gems/ruby-1.9.3-p194/gems/app2engine-0.0.5/lib/app2engine/rake/tasks.rb:36:in define_task' WARNING: DSL method App2Engine::Rake::Tasks#desc called at /Users/mdkarp/.rvm/gems/ruby-1.9.3-p194/gems/app2engine-0.0.5/lib/app2engine/rake/tasks.rb:30:ininitialize' WARNING: DSL method App2Engine::Rake::Tasks#task called at /Users/mdkarp/.rvm/gems/ruby-1.9.3-p194/gems/app2engine-0.0.5/lib/app2engine/rake/tasks.rb:31:in `initialize'

I was trying to convert Team Dashboard (from @fdietz) into an engine to embed in another app. https://github.com/mdkarp/team_dashboard

eregon commented 11 years ago

Hi,

Thank you for reporting, the warnings should be fixed with the above commit.

However, to be honest, there has been some time since I last used app2engine. And Rails engines seem to have changed considerably (and matured). I guess the right path now is reading the Rails Engine guide and using rails plugin new [--mountable] ENGINE_NAME as mentioned in enginex's README. The best therefore is likely to create a new engine skeleton with rails plugin new and move files over from the app. It should ensure a better compatibility across versions and make clearer the changes (e.g.: moving files into the namespace directories for mountable engines).

eregon commented 11 years ago

I would be happy to hear how it went when you will have converted it in an engine, do not hesitate to leave a word about it here.

mdkarp commented 11 years ago

Cool - thanks!