Closed cmc333333 closed 8 years ago
By the way, is it preferable to keep version and label in the same field? I'm wondering if we could have separate columns (with version being nullable) and avoid some confusion (on my part) about building and parsing doc_id strings.
Re splitting out version -- I was originally hoping that we could basically ignore it and treat the combined doc_id like an opaque identifier. Unfortunately, too much other stuff depends on it ATM.
How about I add a comment around that topic and kick the can down the road?
SGTM--I only asked because I was uncertain about the doc_id
format, so I think a comment around that is fine.
Thanks for all the feedback @jmcarp ; ready for another round
:tada:
This adds a
doc_type
field to layers, currently consisting of two values, 'cfr' and 'preamble' (preventing many potential collisions). This also modifies the URL pattern, which used to be/layer/[layername]/[regulation_label_id]/[version_id]
to/layer/[layername]/[doc_type]/[doc_id-which-may-include-slashes]
For backwards compatibility, this adds a translation layer between the old format and the new. It does, however, migrate existing data.For eregs/notice-and-comment#17