Closed jmcarp closed 8 years ago
Makes sense to me. A few more things to consider:
Oh, one more heads up: I think that at some point in the near future, the preamble
won't have a separate endpoint for creation/retrieval; it'll be part of the notice
end points. Behind the scenes, we'll still create the nested models and all that jazz, the end user interface might just be a tad different.
You'll need to replace the function in your migration; not a huge deal to import from a different path. This is the reason it's not good to call external code in migrations, however.
Quick note that the coverage drop is okay -- it's almost exclusively due to additional code in a migration.
Love the direction. Ping @tadhg-ohiggins @porta-antiporta - this will make it pretty easy to add (and search) other types of documents, such as US Code, AOs, etc. so long as they can be described in the Node
structure, which is very generic.
Flantastic!
Preparation for https://github.com/eregs/notice-and-comment/issues/118. This is incomplete, and tests are going to fail--I'm hoping to get a quick 👍 / 👎 on approach from @cmc333333 before finishing the details.
TODO:
Regulation
andPreamble
models