search

eregs / regulations-core

An engine that supplies the API that allows users to read regulations and their various layers.
Creative Commons Zero v1.0 Universal
17 stars 27 forks source link

Account for more corner cases w/ section search. #84

Closed cmc333333 closed 7 years ago

cmc333333 commented 7 years ago

Case 1: A search matches a node's title, but the node doesn't have text. In this situation, we return text for the first child of that node.

Case 2: A search which matches a section, but none of its paragraphs contain all of the search term. Here, we return text for the first child of the section.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.05%) to 93.691% when pulling 9d19e94adaf0814a106e5bfc0b82681c3117fbc5 on 475-better-search into 02522aa56e11c73bd14ce2bd1685539087f3e5a6 on master.

cmc333333 commented 7 years ago

Thanks @tadhg-ohiggins. I'm going to bump the version then merge.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.05%) to 93.691% when pulling 8a634a8da7101ea6a16bd3d97f8264f4daaad486 on 475-better-search into 02522aa56e11c73bd14ce2bd1685539087f3e5a6 on master.