Freeze to django-mptt version to fix set+ tuple error

eregs / regulations-core

An engine that supplies the API that allows users to read regulations and their various layers.

Creative Commons Zero v1.0 Universal

16 stars 27 forks source link

Freeze to django-mptt version to fix set+ tuple error #86

Closed mustyoshi closed 6 years ago

mustyoshi commented 6 years ago

It took me spinning up two fresh machines to narrow this down.

coveralls commented 6 years ago

Coverage remained the same at 93.703% when pulling 231f359d2317e1204b832bbbd15745f9bccc71d9 on mustyoshi:master into d5443336b0ec287e62837614bf1e359465cc30fe on eregs:master.

cmc333333 commented 6 years ago

Thanks so much @mustyoshi !

johnnyporkchops commented 4 years ago

@mustyoshi , At FEC, we forked the eregs/regluations-core repo and tried to update python packages like Django and django-mptt.

Migrations only work with django-mptt 0.8.6 on fec-eregs repo. regcore.0003_mptt_copy_children fails with any later version of django-mptt.
When we upgrade django-mptt (0.9.0/0.11.0) on regulations-core, migrations work. The problem is that on fec-eregs migrations continue to fail with the set+ tuple error that you fixed with this PR.

We are stumped! Since you worked on this before, do you know what the nature of the error is and can you think of any possible workarounds?

mustyoshi commented 4 years ago

@johnnyporkchops, unfortunately I am not very familiar with the django/django-mptt ecosystem, I had only been messing around with this repo. I did some testing, and if you keep the django-mptt version at 0.8.6, the docker image will finish building. I was also able to start the webserver.

cmc was in the process of depreciating the use of django-mptt, so you may have to just live with the outdated version. The good news is that django@2.2.11 does work with django-mptt@0.8.6

Sorry I couldn't be more helpful.