#364: WHED appendix title handling rewritten to complement #359

eregs / regulations-parser

Parser for U.S. federal regulations and other regulatory information

Creative Commons Zero v1.0 Universal

36 stars 40 forks source link

#364: WHED appendix title handling rewritten to complement #359 #367

Closed gregoryfoster closed 7 years ago

gregoryfoster commented 7 years ago

Based on @cmc333333's comments on #365, I've added a get_appendix_title function to regparser/tree/gpo_cfr/appendices.py, removed get_app_title from interpparser/gpo_cfr.py, and replaced all references.

cmc333333 commented 7 years ago

Code looks good to me, though the linter's complaining that you need a newline above get_appendix_title's definition. Happy to do that for you (there should be a checkbox on your PR to allow maintainers to edit your PR) if you don't have time.

gregoryfoster commented 7 years ago

Thank you! Can you point me to how the project is linting code?

cmc333333 commented 7 years ago

Excellent, thanks! We're currently installing a bunch of flake8 plugins and then running flake8 . in travis.

coveralls commented 7 years ago

Coverage increased (+0.002%) to 91.94% when pulling e06cee90fa9b44abb8ebff075753816be69b8072 on gregoryfoster:37_cfr_1_appendix_title into 0c650cda3e09c8abd9485133a65ec255357f7c8b on eregs:master.

cmc333333 commented 7 years ago

Thanks @gregoryfoster !