search

erelsgl / limdu

Machine-learning for Node.js
GNU Lesser General Public License v3.0
1.05k stars 99 forks source link

Release improvement #76

Closed Berkmann18 closed 1 year ago

Berkmann18 commented 1 year ago

IMO, you should use a CI or GitHub Action to at least automatically release new versions (or better use a commit convention like Angular and let semantic-release do the version bumping and release for you), especially as the version on NPM is two patches behind.

With this PR, you'll still need to manually run npm publish, but at least the version should be up-to-date with the changes from my previous PR.

erelsgl commented 1 year ago

This sounds like a good idea, but I am not sure how to start.

Berkmann18 commented 1 year ago

Would you instead use an external CI/CD service like TravisCI/CircleCI or what is more native to GH with Actions like https://github.com/Berkmann18/lh-avg/blob/master/.github/workflows/semantic-release.yml (this uses the following config and expects commits to follow https://www.conventionalcommits.org/en/v1.0.0)? You could even try Rolling Versions, which is apparently a more interactive/user-involved approach (I've not tried that one since I spoke to the creator who wrote a Medium article about that tool). I can help you set up the sytem.

erelsgl commented 1 year ago

Github Actions sounds like a better option. I will be happy for help. Can we schedule a Zoom meeting?

Berkmann18 commented 1 year ago

Sure, do you have a calendar I could put an invite to? I'm generally free from, 12-1pm, 5pm-onwards (GMT) on weekdays (aside for Tuesdays, where I'm only free after 8:30pm) and any time on weekends (with exceptions as I have events on some weekends).

erelsgl commented 1 year ago

Would you like to meet today (Wed.) at 12 PM GMT?

Berkmann18 commented 1 year ago

Just seen this, I had a hectic week. What other day/time could you do?

erelsgl commented 1 year ago

How about today (Sunday), 12pm gmt?

Berkmann18 commented 1 year ago

I was busy pretty much that whole day. Do you have a public/accessible calendar I can put an invite on? This way, it should be easier to find an available time for both of us.

erelsgl commented 1 year ago

I do not have a public calendar, but I am available at Mondays most of the day, so we can schedule a time in the coming Monday.

Berkmann18 commented 1 year ago

Sure, Monday 19th from 6pm (UK time) is good for me.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: