erengy / anitomy

Anime video filename parser
Mozilla Public License 2.0
275 stars 22 forks source link

Wonder.Woman.2017.720p.10bit.BluRay.6CH.x265.HEVC #11

Closed FallingSnow closed 6 years ago

FallingSnow commented 6 years ago

Given Wonder.Woman.2017.720p.10bit.BluRay.6CH.x265.HEVC:

AnitomyElements {
  AnimeTitle: 'Wonder Woman 2017',
  FileExtension: 'mkv',
  FileName: 'Wonder.Woman.2017.720p.10bit.BluRay.6CH.sample',
  Source: 'BluRay',
  VideoResolution: '720p',
  VideoTerm: '10bit' }

Is it possible to identify 2017 as the ReleaseYear rather than part of the title?

erengy commented 6 years ago

Anitomy considers a number to be AnimeYear only if it's isolated within brackets, such as (2017). This is to avoid parsing numbers that are actually a part of the title. Blade Runner 2049 can be given as a recent example from non-anime media, though there are others from past years as well.

Also note that Anitomy is optimized toward anime releases, where release information is usually enclosed within brackets. Having issues with regular movies or TV series is to expected.

This issue is somewhat related to erengy/taiga#417.

FallingSnow commented 6 years ago

I see, thank you for the explanation. I guess it would be too much of an edge case to develop a system where, possibly, (in the above example) 2017 is the year until another year is found later in the file name.

Any whoo, is it possible to get this compiled to wasm via emscripten so that it doesn't need to be recompiled on each host. I am trying to use this along with https://github.com/Xtansia/node.anitomy.js and it requires cmake to be installed. I figure most of this can be avoided by compiling straight to wasm.

Anyway, thank you for this great library. :)

FallingSnow commented 6 years ago

@Xtansia Do you think compiling to wasm is a good idea?