search

erengy / anitomy

Anime video filename parser
Mozilla Public License 2.0
278 stars 22 forks source link

Allow const& access to elements and options #24

Closed Xtansia closed 11 months ago

erengy commented 11 months ago

Hi @Xtansia, thanks for the PR.

May I ask why this is necessary? You cannot call Anitomy::Parse from an immutable object, so you shouldn't need const reference to its members either. Especially the options, since the method is supposed to be used as a setter.

Also note that I'm currently rewriting the library in the develop branch and there's no Anitomy class anymore. Now you just call a free parse function and receive the elements.

Xtansia commented 11 months ago

@erengy This was due to me trying to match up some semantics in Rust bindings. But realise now it's not particularly necessary. So safe to ignore, apologies!