erengy / taiga

A lightweight anime tracker for Windows
https://taiga.moe
GNU General Public License v3.0
2.09k stars 224 forks source link

Recognition fails if year is present and filename matches MAL/Anilist alt title #1152

Open SacredZenpie opened 11 months ago

SacredZenpie commented 11 months ago

Example: Romaji name: Yahari Ore no Seishun Love Come wa Machigatteiru. Zoku: Kitto, Onnanoko wa Osatou to Spice to Suteki na Nanika de Dekiteiru Alt name (on anilist): Yahari Ore no Seishun Love Comedy wa Machigatteiru. Zoku OVA

Filename: Yahari Ore no Seishun Love Comedy wa Machigatteiru. Zoku OVA - gets recognized no problem Filename: Yahari Ore no Seishun Love Comedy wa Machigatteiru. Zoku OVA (2016) - fails

erengy commented 11 months ago

This is intentional. See https://github.com/erengy/taiga/issues/917#issuecomment-760980036.

SacredZenpie commented 11 months ago

I understand, my question is more of a why isnt it being applied to both the actual name and alt name. Why is it only applied to the alt names that is. There are more anime that I can think of that have year in their official title than as synonym.

On Wed, 11 Oct 2023, 01:52 Eren Okka, @.***> wrote:

This is intentional. See #917 (comment) https://github.com/erengy/taiga/issues/917#issuecomment-760980036.

— Reply to this email directly, view it on GitHub https://github.com/erengy/taiga/issues/1152#issuecomment-1756476189, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2ORH3MZDSUXCRAZLK2H3ZLX6XNUZAVCNFSM6AAAAAA52TWXYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJWGQ3TMMJYHE . You are receiving this because you authored the thread.Message ID: @.***>

erengy commented 11 months ago

Filename: Yahari Ore no Seishun Love Comedy wa Machigatteiru. Zoku OVA (2016) - fails

If the anime title in the filename is "Something OVA (2016)", than either the main title or one of the synonyms has to be the same, "Something OVA" is not enough for a match. In this case, you manually add "Something OVA (2016)" as an alternative title and Taiga is able to identify it afterwards.