Please add HEVC and other video types when filtering

erengy / taiga

A lightweight anime tracker for Windows

https://taiga.moe

GNU General Public License v3.0

2.11k stars 229 forks source link

Please add HEVC and other video types when filtering #1217

Open ctcarino opened 2 weeks ago

ctcarino commented 2 weeks ago

my goal is to search only 1080p videos and dont want any form of encoding that has the file size reduction. i can see 3 variants but HEVC is not included.

even the capital letter H.264 is not being filtered out. only h.264. tried manually entering the Video Type in the dropdown but its not working

Screenshot 2024-11-04 115507 Screenshot 2024-11-04 120019

erengy commented 2 weeks ago

You can type anything you want (e.g. HEVC) in the value input. Dropdown values are just recommendations.
Filter comparisons are case insensitive, so there's no issue with H.264 and h.264.
H.264 and H264 are different values. Adding a condition for one won't target the other.
Using contains/does not contain operators instead of is/is not will give you better results for elements that might contain multiple values such as Episode video type (this way you can also get away with just one condition for 264 instead of multiple conditions for H264, H.264 and X264).
You probably want that filter to match Any condition, not All conditions (see #1186). If that's confusing, you can just create separate filters -- one for 1080p and another one for HEVC.

ctcarino commented 2 weeks ago

@erengy tried adding H.264 but after i clicked OK, it removed the dot. also adding HEVC and H264 in the filter doesnt work

also choosing "any condition" will result to nothing.

Screenshot 2024-11-05 025102

ctcarino commented 2 weeks ago

seems separating each filter works but kinda hassle since i had to do it one by one.

Screenshot 2024-11-05 025908

ctcarino commented 2 weeks ago

ok i tried "any" condition aand it seems to be working fine.

but i dont understand why "any" would work? isnt "ANY" is something like an "OR" condition while "ALL" should be "AND" condition?

Screenshot 2024-11-05 030508

erengy commented 2 weeks ago

i dont understand why "any" would work? isnt "ANY" is something like an "OR" condition while "ALL" should be "AND" condition?

When you select the "All conditions" option, all conditions must be true for the action (discarding matching items) to take place. You are basically saying, "discard a torrent if its video resolution is not 1080p and its video type is HEVC and x264 and H.264 at the same time", which is impossible. That's why you use "Any condition" instead.

Don't be too hard on yourself if you don't get it, though. Filters are quite powerful but not exactly user friendly. I intend to simplify them eventually, or at least provide an easier way to handle the most common cases. Suggestions are welcome.