erezak / libphonenumber-csharp

Forking original c# port
Apache License 2.0
198 stars 79 forks source link

huge init time optimization: protobuf & codegen insted of xml #7

Open greshnoff opened 10 years ago

erezak commented 10 years ago

Have you checked this with a Windows Phone? Does it generate code that can be loaded into a phone? This was the original reason I forked the lib.

Ripper555 commented 7 years ago

I have not tested this on windows phone yet. I am running it on Android only right now. I'm using only: PhoneNumberUtil.Normalize(phoneNumber); _phone.Parse(nom, RegionCode.US); _phone.IsValidNumber(ph); _phone.Format(ph, PhoneNumberFormat.E164);

The initialize time on my phone is 3.250 seconds less time. The library is not usable except with these changes.