search

erezgeva / libptpmgmt

Library to communicate with linuxptp using IEEE 1558 management messages over Unix network. The library provide functionality that is provided by the pmc tool of the linuxptp project.
Other
24 stars 5 forks source link

Clock manager observations #14

Open wtedeschi opened 4 days ago

wtedeschi commented 4 days ago

Hello Erez,

Thanks for the great work!

My comments are directed to my former Intel colleagues, but feel free to shine in.

  1. on the proxy application, having a log showing whether libraries are connected could be useful.

  2. the same on the library side, a logger would be welcome, no need to be extensive.

  3. C++ example there are some questions: a. Embedding the clock manager in a class is how code will be used. b. Printf we are in c++, moving the prints to std::court would make more sense. c. Comments on the example are missing, this will help people to look and understand the usage.

  4. interface, please double check this with the other users of the code: a. The event for the range looks strange, as to understand the direction one has to interpret the delay, slowing down processing and increasing code from the users of the library. The best would be to have two events one going in the boundaries and one leaving the boundaries. b. Setting the threshold can be simplified, usually this interval should be asymmetric, i.e. +- a number, adding this interface could simplify usage as well (lower importance as the other interface also serves the same purpose).

Usage; I tried to embed the clock manager example within Python using popen and it didn't work.

Best regards, Fred

erezgeva commented 4 days ago

I will talk to the team in Malaysia tomorrow.

Yes, I know the wrappers are not functional yet. We need some more changes in the API. And some basic testing with the wrapper. I add the infrastructure for the wrappers. But from my experience, they usually need some tuning before they are actually functional. We are not on release state at the moment.

As for IO streams in C++. The IO streams performance for embedded is poor. See also: https://google.github.io/styleguide/cppguide.html#Streams

I usually prefer that libraries would not print directly and pass through the user application (with a callback). Allow the developer to redirect the output as they wish. Perhaps to a logger, or maybe to a GUI. We will probably change this one, though, I can not promise on first release. We care more on stability and reliable when we release. And keep backward comparable with API and ABI A callback like that would probably be an optional.

As for the proxy, A C printing also make it easier with Linux logging API, which is also C. In principle we use C Linux system calls directly. We do not plan to add a C++ library for Linux logging.