erfanoabdi / ErfanGSIs

Just a tool to make GSI out of firmware from any phone
GNU General Public License v3.0
491 stars 450 forks source link

this is to fix github actions error #176

Open nit-in opened 2 years ago

nit-in commented 2 years ago

the LEAVE function is being used for stopping the script gracefully but it is also being used in the end for exiting after script have ran successfully, this might not break the build in local host but causing an error in Github actions as the script exits with exit 1, which is considered as failure (in bash) even when the output gsi image is created successfully, this https://github.com/nit-in/erfan_gsi_mmx_6746/actions/runs/1206555548 run might give an idea as the gsi is created but workflow fails Solution: using other function BYE or exit 0 at the end

Signed-off-by: nit-in nit_in@live.com

Velosh commented 2 years ago

Why is this necessary? Since you can fork it instead of pushing dummy code to official repo. In my opinion, no need to do it. You can try to use || (if fail) to exit 0 code, maybe.

erfanoabdi commented 2 years ago

make it dependent on CLEAN argument