Set Default RuntimeIdentifier to win-x64

erfg12 / AOL_4.0_Emu

Emulating AOL 4.0

https://aolemu.com

103 stars 8 forks source link

Set Default RuntimeIdentifier to win-x64 #46

Closed amaitland closed 2 years ago

amaitland commented 2 years ago

If no runtime identifier set then will default to win-x64
Remove x64 platform from solution
Remove .net 4.6.1 system.dll framework reference

This will dramatically reduce the size as as all the other platform dlls won't be included.

If you wish to support x64/x86/arm64 then I'd suggest publishing for each target.

erfg12 commented 2 years ago

I removed the references to .NET Framework, but I added these:

<CefSharpAnyCpuSupport>true</CefSharpAnyCpuSupport>
<CefSharpBuildAction>Content</CefSharpBuildAction>
<RuntimeIdentifier Condition="'$(RuntimeIdentifier)' == ''">$(NETCoreSdkRuntimeIdentifier</RuntimeIdentifier>
<PlatformTarget Condition="'$(PlatformTarget)' == ''">x64</PlatformTarget>

Appveyor now specifies target Release, Any CPU. CefSharp seems to work now. I'm sure there are some modifications we can make to the Appveyor.yml file to shrink the size of the Build.zip

amaitland commented 2 years ago

Your csproj file still could be simplified

Remove the chromiumembeddedframework.runtime update entries
Remove the CefSharpAnyCpuSupport property as not relevant for targeting. Net 6
WCFMetadata should probably be removed as WCF was not ported to .Net 6

Changing to a release build is an improvement, using dotnet publish is what Microsoft recommends for generating builds you plan to distribute.