Closed ytoml closed 2 years ago
For now, we have a lot of clippy warnings left untouched. In this PR, I fixed them all but below (just suppressing with attributes).
clippy
To avoid API Breaking changes: module/crate level
clippy::derive_hash_xor_eq
clippy::large_enum_variant
clippy::result_unit_err
local
clippy::should_implement_trait
clippy::wrong_self_convention
clippy::too_many_arguments
To preserve readability:
clippy::needless_range_loop
clippy::useless_conversion
into_iter
@mtshiba
And now we can set CI for clippy after this PR.
I added clippy checks to pre-commit and GitHub Actions. Thank you!
For now, we have a lot of
clippy
warnings left untouched. In this PR, I fixed them all but below (just suppressing with attributes).To avoid API Breaking changes: module/crate level
clippy::derive_hash_xor_eq
for erg_typeclippy::large_enum_variant
for erg_compiler, erg_parser, erg_compilerclippy::result_unit_err
for erg_compiler/contextlocal
clippy::result_unit_err
in erg_common/tsort.rsclippy::should_implement_trait
in erg_parser/ast.rs, lex.rsclippy::wrong_self_convention
in erg_compiler/context/compare.rsclippy::too_many_arguments
in erg_compiler/context/mod.rsTo preserve readability:
clippy::too_many_arguments
in erg_compiler/context/mod.rsclippy::needless_range_loop
in erg_common/levenshtein.rsclippy::useless_conversion
in erg_compiler/context/compare.rs (to keep explicitinto_iter
as coding rule requires)@mtshiba