erg-lang / erg

A statically typed language compatible with Python
http://erg-lang.org
Apache License 2.0
2.63k stars 54 forks source link

Move lib to the root directory #353

Closed C-BJ closed 1 year ago

C-BJ commented 1 year ago

Since els is integrated into the erg, lib is no longer needed as a dependency, so you can move lib to where it should be

@mtshiba

mtshiba commented 1 year ago

The reason lib is in erg_compiler is because erg_compiler is a standalone crate that depends on lib. els is not relevant.

C-BJ commented 1 year ago

Yes, I know. But since els is moved to erg, is it not necessary to include the lib in erg_compiler?

C-BJ commented 1 year ago

If change the location of lib, is there any problem? @mtshiba

mtshiba commented 1 year ago

cargo install erg_compiler must work properly. Means lib must be installed.

I don't know if cargo allows specifying resources like ../../. Is this allowed?

C-BJ commented 1 year ago

cargo install erg_compiler must work properly. Means lib must be installed.

I don't know if cargo allows specifying resources like ../../. Is this allowed?

I'll go and see.

C-BJ commented 1 year ago

btw, Do you think the name of the compiler folder in the root directory should be changed, such as core. Because it includes els and maybe other things in the future

mtshiba commented 1 year ago

I'm considering renaming the compiler directory to something like crates.

C-BJ commented 1 year ago

yeah, great

C-BJ commented 1 year ago

But after rewriting it with erg, isn't it a strange name

mtshiba commented 1 year ago

Renaming the directory is a trivial matter, as it would be a massive change if Erg were to be rewritten by itself.

C-BJ commented 1 year ago

yeah

C-BJ commented 1 year ago

I think I've done it @mtshiba

C-BJ commented 1 year ago

I don't know how to test

mtshiba commented 1 year ago

I tried to publish erg_compiler. After all, it seems that such a specification is not possible.

スクリーンショット_20230114_154751

couldn't read build.rs: The specified file could not be found

mtshiba commented 1 year ago

Same result.

How about making a small dummy crate to test it out?

C-BJ commented 1 year ago

ok