erg-lang / erg

A statically typed language compatible with Python
http://erg-lang.org
Apache License 2.0
2.7k stars 55 forks source link

ci: update yml #388

Closed C-BJ closed 1 year ago

C-BJ commented 1 year ago

Changes proposed in this PR:

@mtshiba

mtshiba commented 1 year ago

Why tests and builds are run independently is to reduce CI run time.

This change should basically make CI time worse (though there will be a cache effect).

C-BJ commented 1 year ago

I see, But I don't understand the purpose of build and check

toddlerer commented 1 year ago

The reason I used cargo build instead of cargo check is that cargo check does not allow for some checks(ref). I didn't leave my intentions in a comment out, so I guess I didn't get the message.

C-BJ commented 1 year ago

I mean, why don't we just test it? without build and check?

mtshiba commented 1 year ago

The advantage is that when CI fails, it is easy to see whether the build or the test has failed.

C-BJ commented 1 year ago

I see