search

erg-lang / erg

A statically typed language compatible with Python
http://erg-lang.org
Apache License 2.0
2.69k stars 55 forks source link

Change the wrong placement of pull_request_template.md #78

Closed C-BJ closed 2 years ago

C-BJ commented 2 years ago

@mtshiba

mtshiba commented 2 years ago

Placing it in the location would seem to allow for multiple PR templates (though I have only prepared one yet).

image

C-BJ commented 2 years ago

Placing it in the location would seem to allow for multiple PR templates (though I have only prepared one yet).

image

A single template should not be placed in a folder Now it is invalid @mtshiba

C-BJ commented 2 years ago

image @mtshiba

mtshiba commented 2 years ago

Now I created a template for bug fix and that for implementing new features, is it still invalid?

C-BJ commented 2 years ago

Now I created a template for bug fix and that for implementing new features, is it still invalid?

Yes @mtshiba

mtshiba commented 2 years ago

I see. It seems that if there are multiple PR templates here, you have to add ?template=template_name.md to the PR creation URL. This is a hassle, so let's not do this.