ergo-auction-house / frontend

User interface of Auction House.
2 stars 0 forks source link

Old collections (minted before EIP-34) #48

Closed maritsaart closed 1 year ago

maritsaart commented 1 year ago

@anon-real earlier you wrote discord #development 12/08/2022 - We are thinking about importing other marketplaces' data such as sales and collections to AH which makes our price history and transition for artists very easy. For sales, it is easy. For collections since other marketplaces, unfortunately, started having collections without an EIP, collections they have are basically centralized and written only in some DB. Still, we are thinking of ways to let artists have their already existing collections in the new AH.

I have more than 40 collections at 3 addresses, I am very interested in this feature 🙏 twitter maritsaart - collections overview

anon-real commented 1 year ago

Yes, this is still our plan.

maritsaart commented 1 year ago

@anon-real "there was no standard to be backward compatible for" - and who is stopping you from making changes or making a second / third version of the standard? You are an author and developer of this EIP.

"Technically, the proposed solutions (just showing metadata in the UI)" I don't understand the passage about UI. I propose to store the list of NFT IDs on the blockchain in an AHv3 collection token (or something similar). Yes, there could be problems. For example, with the scam attempt to add NFTs from other authors. But this can be solved at the creation stage - allow only those NFTs that was minted on the addressES (1+!) associated with the account.

There is an example of a token with a list of IDs in my amateur MVP for the "Collection token" and the "Linked storage" (autumn 2022): Token with list of tokenIDs in [R5], Tx

Offtopic Collection Token - on-chain svg in [R9] with JS script which use data from token with a list of IDs, loading and showing all images as grid (see screenshot). With this MVP I tried to solve two problems: 1) somehow bypass the 4Kb limit for on-chain image storage (for more or less interesting images, I need 10-25Kb); 2) somehow organize tokens from collections minted before the adoption of the EIP-0034 standard (I have 40+ collections in different styles).

Full version on Discord: MVP, why MVP and why stopped Some explanations: vulnerabilities, expl2, why stop

Animal_pop_art_00_Collection_Token

maritsaart commented 1 year ago

@anon-real

maritsaart (1) "allow only those NFTs that was minted on the addressES (1+!) associated with the account."

anon-real "blockchain is permissionless, we can not enforce people not to do something in the UI only. Contracts should enforce that."_

When minting a collection, a list of associated addressES is determined. What prevents you from doing check (1) in a smart contract?

AH team do collections verification outside the blockchain, by people's hands. There are not many Ergo's OGs with the problem of this topic. I think up to 20 artists, half of them are inactive for a year+ and will not return to Ergo. Therefore, the argument that check (1) can only be done on the blockchain is very controversial. So I don't understand why check (1) can't be done on the AH site backend. Or even in manual mode for those 10-20 artists - I mean minting some specific token or SC with specific rules or ... - you know better.

maritsaart commented 8 months ago

@anon-real earlier you wrote discord #development 12/08/2022 - We are thinking about importing other marketplaces' data such as sales and collections to AH which makes our price history and transition for artists very easy. For sales, it is easy. For collections since other marketplaces, unfortunately, started having collections without an EIP, collections they have are basically centralized and written only in some DB.

Any news on import SkyHarbor sales history to AH v.3?

Animal pop art #26. Turtle SH Sale: 50 ERG 19.11.2023 Tx

AH v.3: No sales yet!