Fix/andi/cornice - Githubissues

ergo / pyramid_apispec

Pyramid plugin for openapi spec generation (using ApiSpec)

BSD 3-Clause "New" or "Revised" License

23 stars 10 forks source link

Fix/andi/cornice #10

Closed pansen closed 5 years ago

pansen commented 5 years ago

Fix the bug described in https://github.com/ergo/pyramid_apispec/issues/9
add some convenience Makefile for easy local dev-setup

Please let me know if I should remove the make stuff.

ergo commented 5 years ago

Requires formatting fix with black.

ergo commented 5 years ago

Feel free to have the make there, just remove its mentions from documentation for now :)

ergo commented 5 years ago

Oh and please sign the CLA in AUTHORS.md, thanks.

christian-heusel commented 5 years ago

Thank you alot for your work @pansen :heart:

Since the fix works (atleast for me) it would be nice to have it merged into mainline so we can avoid ugly fixes.. @ergo :blush: (i.e. mount a docker volume with the fixed version)

Will this happen anytime soon?

ergo commented 5 years ago

@TheEbolaDoc, I would love to merge that asap. Just needs signoff on the CLA.

ergo commented 5 years ago

I could probably take the actual bits @pansen changed for cornice support (or write something similar of my own) and write my own test. But IMO he did a great job here so I think we can wait a bit for him to add himself to authors file so everyone is properly attributed.

ergo commented 5 years ago

Fixed by different implementation, but thanks for your contribution!