search

ergochat / ergo

A modern IRC server (daemon/ircd) written in Go.
https://ergo.chat/
MIT License
2.27k stars 180 forks source link

reevaluate "insecure reattach" error #2013

Closed slingamn closed 1 year ago

slingamn commented 1 year ago

See #955 for some context. Bouncer reattach that mixes secure and insecure connections has been disallowed ever since the functionality was first built (in c2faeed4b515033a6e1029572b55315f45f010f2). The following year (998ac6928b904f6cab64aec4b8881dd9327fd0ab) we removed the plaintext listener by default.

Ever since, it seems like most errors due to mixing secure and insecure connections are spurious: the connection is actually secure, but is being transported over an incorrectly configured reverse proxy (e.g. WEBIRC is being sent without the secure flag, or a websocket is being proxied without adding X-Forwarded-Proto: https). It may be time to delete this check; we are already pushing operators hard to disable plaintext, and it's not clear what purpose it serves if plaintext is enabled nonetheless (the SASL PLAIN handshake is still being transmitted and acknowledged in plaintext, we just don't allow the reattach).

slingamn commented 1 year ago

Question: should we be trying to prevent clients from mixing Tor and non-Tor? (I thought we were already doing this, but we are not, so it would be a compatibility break.)

Mikaela commented 1 year ago

Question: should we be trying to prevent clients from mixing Tor and non-Tor? (I thought we were already doing this, but we are not, so it would be a compatibility break.)

No. That will mess up people like me who are just using Tor to provide cover traffic for those actually depending on Tor (or just attempting to normalise its use) and harm especially iOS users.

Additionally it will hurt at least one network I oper on as I don't need anonymity or privacy from myself while using Tor to connect there lets me know if we have an issue with the Tor node or otherwise helps with troubleshooting if someone asks about it or claims it to not be working.