Example of the fixed output: :oragono.test 400 netcat REHASH :yaml: unmarshal errors: line 594: cannot unmarshal !!map into []logger.LoggingConfig
Replacing 400 ERR_UNKNOWNERROR with FAIL isn't such a good idea after all. FAIL requires a code and we don't have one specified for this case (or most of the other cases where we currently send a 400). A code of * would probably work but needs some discussion.
Sanitize the in-band error message from REHASH
Example of the fixed output:
:oragono.test 400 netcat REHASH :yaml: unmarshal errors: line 594: cannot unmarshal !!map into []logger.LoggingConfig
Replacing
400 ERR_UNKNOWNERROR
withFAIL
isn't such a good idea after all.FAIL
requires a code and we don't have one specified for this case (or most of the other cases where we currently send a 400). A code of*
would probably work but needs some discussion.