don't send multiline responses to CAP LS 301

ergochat / ergo

A modern IRC server (daemon/ircd) written in Go.

https://ergo.chat/

MIT License

2.27k stars 180 forks source link

don't send multiline responses to CAP LS 301 #2068

Closed slingamn closed 1 year ago

slingamn commented 1 year ago

This is more or less explicitly prohibited by the spec:

https://ircv3.net/specs/extensions/capability-negotiation.html#multiline-replies-to-cap-ls-and-cap-list

See https://github.com/progval/irctest/pull/205 ; #2065 here caused the CAP LS 301 response to spill onto two lines, breaking SASL in irssi and possibly other clients.

slingamn commented 1 year ago

This should get a changelog entry because it technically changes the behavior (some draft caps will be hidden from 301 clients now; it's theoretically possible that this affects someone's scripted extension).

slingamn commented 1 year ago

Relative to 2.11, we will be hiding: cap-notify draft/account-registration draft/channel-rename draft/languages draft/multiline draft/persistence draft/read-marker extended-monitor