search

ergochat / ergo

A modern IRC server (daemon/ircd) written in Go.
https://ergo.chat/
MIT License
2.21k stars 176 forks source link

NS CERT ADD <self> <certfp> should not require privileges #2098

Closed slingamn closed 4 months ago

slingamn commented 8 months ago

https://github.com/ergochat/ergo/blob/5671ee2a36c01b480b3b56b6eafdc57a789538ea/irc/nickserv.go#L368-L374

The two-argument case fails without privileges even when the user is trying to act on their own account:

https://github.com/ergochat/ergo/blob/5671ee2a36c01b480b3b56b6eafdc57a789538ea/irc/nickserv.go#L1414-L1418

We should detect that the user is acting on themself and make this succeed.

slingamn commented 4 months ago

Resolved by #2128