search

ergochat / ergo

A modern IRC server (daemon/ircd) written in Go.
https://ergo.chat/
MIT License
2.21k stars 176 forks source link

Real name length not checked #2123

Closed eskimo closed 5 months ago

eskimo commented 5 months ago

Seems like real name isn't checked for length, making you able to end up with names like this. Definitely not ideal.

[11:09:49] butts has userhost ~0@w3beg2gmmqdvw.igloo and real name "ha hiopsdgio hjgds hjoidgsh iogds hiodgs hoidsg hiodgs hiodgsj iophdsgj piodgs hjpiodgs hiodgs hoidsg hoidsg hoisdhoidsghiodsg hiodsg hiosihosd ohidsg hiodgs hiodgs hoiadghio adgohidgs hoidsg hiosdg hio hiogdsh iodsgh iobds hiods hiosdgh iodbsh iosbdh oibdxh iodxb hoidbxshio dsg hiodsg hiodsg hiodsgioh dgsh iodsg hiodgs hiodsg hiodsgohi dgs hiodgs hiodsg hiodsghio ds hiobds hiodbxsohi bdsh iobdh oidsvbho ibdxs hoidsb hiodsb jidbsj iohbds jhiopbds"

slingamn commented 5 months ago

Good candidate for adding to the limits block:

https://github.com/ergochat/ergo/blob/d97e964b35a206b78f7b472e3c1cf17cfbd4059f/default.yaml#L815-L821

slingamn commented 5 months ago

Anyone have thoughts on a recommended default? Maybe 200-300 chars

eskimo commented 5 months ago

I honestly think 100 is more than enough.

slingamn commented 5 months ago

Libera does 50 (!?), Inspircd testnet does 130

eskimo commented 5 months ago

Yeah I think 100-120 is pretty fair, leaves enough room for 99% of people to fit their name and email which is common. 50 is probably too low.