search

ergodicio / tsadar

The Thomson scattering diagnostic offers a method by which to infer plasma parameters such as n_e, T_e. This approach uses the form factor equations to estimate those plasma parameters by fitting to observed Thomson scattering spectra.
2 stars 2 forks source link

Re-enable ADAM for 1D (non-angular) analysis #42

Closed joglekara closed 9 months ago

joglekara commented 9 months ago

See https://continuum.ergodic.io/experiments/#/experiments/298/runs/4f51caccbed94c699ea9eeb1437771ba vs https://continuum.ergodic.io/experiments/#/experiments/298/runs/231ca63bf4714e71a56921615d11c6fb

joglekara commented 9 months ago

The main difference between ADAM (from JAXopt) and L-BFGS-B (from SciPy) is that the latter has an auto-convergence stop and often terminates fairly early (for better or worse). The former requires us to implement that.

Right now, it just runs to the maximum number of steps specified in the config and returns the parameters from the step with the best loss. It will be useful to implement an early stopping condition

It will then be useful to unify the codepath for 1D lineouts and branch where needed (optimizer in this case).

Then it will be useful to extend this to angular

joglekara commented 9 months ago

Also did some refactoring with the file storage