search

ergodicio / tsadar

The Thomson scattering diagnostic offers a method by which to infer plasma parameters such as n_e, T_e. This approach uses the form factor equations to estimate those plasma parameters by fitting to observed Thomson scattering spectra.
2 stars 2 forks source link

"refit: True" not working #48

Closed zachbarfield60 closed 5 months ago

zachbarfield60 commented 9 months ago

Toggling on "refit" is not working. When running with 

other:
    refit: True

I receive the following error after the code finishes its first pass:

`Traceback (most recent call last):
  File "/global/u2/z/zachb/inverse-thomson-scattering/run_tsadar.py", line 21, in <module>
    run_job(args.run_id, nested=None)
  File "/global/u2/z/zachb/inverse-thomson-scattering/inverse_thomson_scattering/runner.py", line 128, in run_job
    _run_(config, mode="fit")
  File "/global/u2/z/zachb/inverse-thomson-scattering/inverse_thomson_scattering/runner.py", line 97, in _run_
    fit_results, loss = fitter.fit(config=config)
  File "/global/u2/z/zachb/inverse-thomson-scattering/inverse_thomson_scattering/fitter.py", line 409, in fit
    final_params = postprocess.postprocess(config, batch_indices, all_data, all_axes, ts_fitter, sa, fitted_weights)
  File "/global/u2/z/zachb/inverse-thomson-scattering/inverse_thomson_scattering/process/postprocess.py", line 194, in postprocess
    new_weights = np.zeros(ts_fitter_refit["init_weights"].shape)
TypeError: 'TSFitter' object is not subscriptable
srun: error: nid002917: task 0: Exited with exit code 1
srun: Terminating StepId=20514285.0`
joglekara commented 9 months ago

Yes I definitely broke the refitter

almilder commented 5 months ago

The updated main branch includes a fix for refitting