ergoemacs / ergoemacs-mode

ergoemacs-mode
ergoemacs.github.io/
GNU General Public License v3.0
293 stars 35 forks source link

Cannot use some commands in Helm #337

Closed tuhdo closed 9 years ago

tuhdo commented 9 years ago

If I have a Helm command with multiple sources, I normally switch using C-o. However, it seems to be shadowed by file opening in Ergoemacs. Probably we should temporary disable Ergoemacs key bindings when a Helm session is alive, except for the predefined keys Alt + i/j/k/l?

Currently, I cannot go up a directory with C-l in helm-find-files. What C-l does is that it jump up a directory level, not deleting part of parent directory name.

mattfidler commented 9 years ago

Currently ergoemacs-mode doesn't actually define the helm equivalents of Alt+i/j/k/l, it looks through the helm keymaps and redefines the keys based on ergoemacs-mode bindings, so disabling all the keys would be a bit more difficult.

The default global map uses C-o for open-line. This is different from the open line you describe in #339 (It appears the community is segmented on this issue). If you defined a ergoemacs-mode theme option that includes open-line, then that command key would also switch between multiple sources.

If C-o makes more sense to open multiple sources in helm (which makes sense to me), it can also be defined to change to switch sources by C-o by an additional theme option. Same with C-l.

mattfidler commented 9 years ago

I have added an option to ergoemacs-mode to satisfy these two cases.