search

ergoemacs / ergoemacs-mode

ergoemacs-mode
ergoemacs.github.io/
GNU General Public License v3.0
293 stars 35 forks source link

compile error (5.14.7.3.1, emacs 24.5): `ergoemacs-translation-regexp' declared after its first use #348

Closed dunn closed 9 years ago

dunn commented 9 years ago

make build fails with the following error:

ergoemacs-theme-engine.el:721:1:Error: Variable `ergoemacs-translation-regexp' declared after its first use

On Mac OS 10.10.4; let me know if there's any other info you need!

mattfidler commented 9 years ago

Thanks,

What version of ergoemacs-mode are you using?

I've been working on a new branch that should mostly compatible with emacs 25

On Fri, Jul 24, 2015, 12:47 AM Alex Dunn notifications@github.com wrote:

make build fails with the following error:

ergoemacs-theme-engine.el:721:1:Error: Variable `ergoemacs-translation-regexp' declared after its first use

On Mac OS 10.10.4; let me know if there's any other info you need!

— Reply to this email directly or view it on GitHub https://github.com/ergoemacs/ergoemacs-mode/issues/348.

dunn commented 9 years ago

Thanks! I was trying to build the 5.14.7.3.1 release.

mattfidler commented 9 years ago

Did you get it from melpa, melpa stable elpa or git?

On Fri, Jul 24, 2015, 7:18 PM Alex Dunn notifications@github.com wrote:

Thanks! I was trying to build the 5.14.7.3.1 release.

— Reply to this email directly or view it on GitHub https://github.com/ergoemacs/ergoemacs-mode/issues/348#issuecomment-124774683 .

dunn commented 9 years ago

The GitHub tarball.

mattfidler commented 9 years ago

If you replace the makefile with:

EMACS=emacs

EMACS_CLEAN=-Q
EMACS_BATCH=$(EMACS_CLEAN) --batch
#TESTS=ergoemacs-test-apps-copy
#TESTS=ergoemacs-test-issue-184-paste
TESTS=ergoemacs-

CURL=curl --silent
TMP1=$(shell pwd)
EMPTY=
BACKSLASH=\$(EMPTY)
SLASH=/
WORK_DIR=$(subst $(BACKSLASH),$(SLASH),$(TMP1))
PACKAGE_NAME=$(shell basename $(TMP1))
AUTOLOADS_FILE=$(PACKAGE_NAME)-autoloads.el
TRAVIS_FILE=.travis.yml

.PHONY : build downloads downloads-latest autoloads test-autoloads test-travis \
         test test-interactive clean edit test-dep-1 test-dep-2 test-dep-3     \
         test-dep-4 test-dep-5 test-dep-6 test-dep-7 test-dep-8 test-dep-9

build :
    $(EMACS) $(EMACS_BATCH) -L . --eval             \
        "(progn                                \
          (batch-byte-compile))" *.el

build2 : 
    $(EMACS) $(EMACS_BATCH) -L . -l ergoemacs-mode --eval             \
        "(progn                                \
          (batch-byte-compile))" *.el

autoloads :
    @cd $(WORK_DIR)
    $(EMACS) $(EMACS_BATCH) --eval                       \
        "(progn                                          \
          (setq generated-autoload-file \"$(WORK_DIR)/$(AUTOLOADS_FILE)\") \
          (update-directory-autoloads \"$(WORK_DIR)\"))"

test-autoloads : autoloads
    @$(EMACS) $(EMACS_BATCH) -L . -l "./$(AUTOLOADS_FILE)"      || \
     ( echo "failed to load autoloads: $(AUTOLOADS_FILE)" && false )

test-travis :
    @if test -z "$$TRAVIS" && test -e $(TRAVIS_FILE); then travis-lint $(TRAVIS_FILE); fi

test : build build2 test-dep-1 test-autoloads ert

ert :
    $(EMACS) $(EMACS_BATCH) -L . -L .. -l cl -l ergoemacs-mode -l ergoemacs-test --eval \
        "(progn                                          \
          (fset 'ert--print-backtrace 'ignore)           \
          (ert-run-tests-batch-and-exit '(and \"$(TESTS)\" (not (tag :interactive)))))" || exit 1; \

clean :
    @rm -f $(AUTOLOADS_FILE) 
    @rm -f *.elc 
    @rm -f *~

Does it compile correctly?

dunn commented 9 years ago

Yeah, removing error-on-warn allows it to compile successfully.