ergoemacs / ergoemacs-mode

ergoemacs-mode
ergoemacs.github.io/
GNU General Public License v3.0
293 stars 35 forks source link

Possible to make ergoemacs do not force user to fetch other packages? #454

Closed abelardojarab closed 3 years ago

abelardojarab commented 7 years ago

I used to love ergoemacs; but there are some features I do not agree very much (no intention to offend at all).

  1. If I control the status of my emacs packages by my self (using use-package; in addition to my own repositories forked from those packages); can I disable ergoemacs to try to connect to melpa? i find that behavior intrusive and does not work well if i already have those packages installed; also doesnt work well if I dont have internet connection.

  2. I was able to add code into ergoemacs to disable connection to melpa (i have not made a pull request into this git repository though, yet) but I still see that there are several add-hook that are added into the eval-expression and the emacs load-theme. Is it possible to disable the hooks on load-theme

i have my repository here (thanks again for the understanding; i work for Intel in Linux driver development so I will be glad to help and contribute code if you would like too :)) bests there Abelardo

https://github.com/abelardojarab/emacs-config

abelardojarab commented 7 years ago

the ergoemacs mode i have i posted in my markdown readme was Fixed ergoemacs-mode, such that it does not invoke (package-initialize) in case there is no Internet connection

but truly i should not say 'fixed it' but changed code to not invoke package initialize. so i was able to disable the package initialize; but the hooks remain and when i try to change theme i keep getting 'exceeded maximum stack depth'....

i would love to start using ergoemacs again; could you please provide workaround. thanks for understanding.

abelardojarab commented 7 years ago

To help debugging; I deleted all files in my git fork of ergoemacs repository and did a clean git subtree pull inside my main emacs configuration repository

after i pulled my repository https://github.com/abelardojarab/emacs-config

when i invoke: "helm-themes" emacs gets unresponsive (locked) and i have to kill the process C-g doesnt work.

can you please help me

mattfidler commented 7 years ago

I thought I fixed that here: 7df155e52c86e1db5e69c16830643adfdf7cd1a8

mattfidler commented 7 years ago

I don't think package-initialize causes the download from melpa, but rather the package-refresh-contents

mattfidler commented 7 years ago

I'm a bit confused about what you are after for your item 2. Do you mean suppress all ergoemacs-mode hooks while running the load-theme?

abelardojarab commented 7 years ago

Hi Matt I hope you are well. the situation is i download ergoemacs-mode as one of my subdirectories inside .emacs.d/

i loaded ergoemacs mode and after i run "helm-themes"; which I got from here https://github.com/syohex/emacs-helm-themes

just invoking 'helm-themes' after loading ergoemacs-mode completely freezes emacs. Ctrl-g does not work and I have to kill emacs. I am using emacs 25.1

mattfidler commented 7 years ago

I tried to reproduce this and I could not.

On Tue, May 9, 2017, 8:06 PM Abelardo Jara-Berrocal < notifications@github.com> wrote:

Hi Matt I hope you are well. the situation is i download ergoemacs-mode as one of my subdirectories inside .emacs.d/

i loaded ergoemacs mode and after i run "helm-themes"; which I got from here https://github.com/syohex/emacs-helm-themes

just invoking 'helm-themes' after loading ergoemacs-mode completely freezes emacs. Ctrl-g does not work and I have to kill emacs. I am using emacs 25.1

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/ergoemacs/ergoemacs-mode/issues/454#issuecomment-300344755, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfa2uHhbBRoABuJf9JyBV0iUQqEwZwsks5r4Q2RgaJpZM4NVkPr .

abelardojarab commented 7 years ago

Hi Matt

First thanks a lot for the help. I use Emacs for C/C++ driver development for FPGA accelerators.

My repository is here: https://github.com/abelardojarab/emacs-config

i have a .emacs and .emacs.d inside. I create symbolic links to .emacs file and .emacs.d at the root of my home directory (i.e. $HOME or ~/ )

I used git subtree to fetch ergoemacs repository.

After Emacs finishes startup sequence and without loading ergoemacs-mode yet; if you input M-x helm-themes you will see that you can switch themes normally. I added defadvice to change the fringe color and the tabbar colorset and the powerline colorset when a new theme is loaded; as I was dissapointed that load-theme didnt adjust neither fringe, tabbar and powerline colorsets.

So you will see that M-x helm-themes will work well without ergoemacs-mode

but after loading ergoemacs-mode

a. M-x helm-themes will freeze Emacs completely b. months ago if i run helm-themes after loading ergoemacs-mode and disabling package-related functions inside Ergoemacs codebase Emacs would not hang but would helm-themes would give an error of maximum stack depth reached; but this was months ago; now invoking M-x helm-themes just freezes Emacs

could you please give me a hand with this? i would love to start using Ergoemacs mode again.

mattfidler commented 3 years ago

Done