search

ergoemacs / ergoemacs-mode

ergoemacs-mode
ergoemacs.github.io/
GNU General Public License v3.0
293 stars 35 forks source link

Emacs26 fixes #468

Closed m00natic closed 7 years ago

m00natic commented 7 years ago

Trunk GNU Emacs with ergoemacs-mode for some time was going into endless loop on load due to improperly sending 2 forms for evaluation to the outside emacs process (versions 25 and below seem more tolerant and do the right thing, but). Here's Messages snippet which is repeated until C-g is invoked:

Cache reset before loading. Loading /home/andrey/.emacs.d/elpa/ergoemacs-mode-20170723.1921/ergoemacs-command-loop.el (source)... Loading /home/andrey/.emacs.d/elpa/ergoemacs-mode-20170723.1921/ergoemacs-advice.el (source)... Loading /home/andrey/.emacs.d/elpa/ergoemacs-mode-20170723.1921/ergoemacs-component.el (source)... Loading /home/andrey/.emacs.d/elpa/ergoemacs-mode-20170723.1921/ergoemacs-debug.el (source)... Loading /home/andrey/.emacs.d/elpa/ergoemacs-mode-20170723.1921/ergoemacs-functions.el (source)... Loading ‘ergoemacs-functions’: unescaped character literals `?"' detected! Loading /home/andrey/.emacs.d/elpa/ergoemacs-mode-20170723.1921/ergoemacs-key-description.el (source)... Loading /home/andrey/.emacs.d/elpa/ergoemacs-mode-20170723.1921/ergoemacs-layouts.el (source)... Loading /home/andrey/.emacs.d/elpa/ergoemacs-mode-20170723.1921/ergoemacs-lib.el (source)... Loading /home/andrey/.emacs.d/elpa/ergoemacs-mode-20170723.1921/ergoemacs-map.el (source)... Loading /home/andrey/.emacs.d/elpa/ergoemacs-mode-20170723.1921/ergoemacs-map-properties.el (source)... Loading /home/andrey/.emacs.d/elpa/ergoemacs-mode-20170723.1921/ergoemacs-mapkeymap.el (source)... Loading /home/andrey/.emacs.d/elpa/ergoemacs-mode-20170723.1921/ergoemacs-theme-engine.el (source)... Loading /home/andrey/.emacs.d/elpa/ergoemacs-mode-20170723.1921/ergoemacs-translate.el (source)... Loading two-column... Loading /home/andrey/.emacs.d/elpa/ergoemacs-mode-20170723.1921/ergoemacs-themes.el (source)... Warning (ergoemacs): Could not find global map information Loading /home/andrey/.emacs.d/recentf... Cleaning up the recentf list... Cleaning up the recentf list...done (0 removed) Ergoemacs-mode turned ON (us:standard). Started ‘ergoemacs-mode’. Total startup time 3.566119 (Load: 3.073180, Initialize:0.492938) Trailing garbage following expression: (kill-emacs)

This is fixed with a87fae7.

The second commit 4e188fd addresses the warning from above where double quotes are improperly escaped.

mattfidler commented 7 years ago

Thanks.

I guess emacs 26 is coming out soon. Perhaps I should try it.