ergoemacs / ergoemacs-mode

ergoemacs-mode
ergoemacs.github.io/
GNU General Public License v3.0
293 stars 35 forks source link

Apps/Menu key functionality #511

Closed TinaRussell closed 2 years ago

TinaRussell commented 2 years ago

Any chance we’ll see the return of the Apps/Menu key functionality in ErgoEmacs? I’ve grown dependent on it over the years; I’m not really sure how to use Emacs without it :cold_sweat:

I mean the translation aspect (e.g. \<apps> f s becomes C-c C-s) but also the custom shortcuts (e.g. \<apps> n t activates org-capture).

mattfidler commented 2 years ago

Yes. It is a available in reduction but it is an oversight that it wasnt abailable in standard ergoemacs

On Tue, Nov 2, 2021, 12:50 AM Tina Russell @.***> wrote:

Any chance we’ll see the return of the Apps/Menu key functionality in ErgoEmacs? I’ve grown dependent on it over the years; I’m not really sure how to use Emacs without it 😰

I mean the translation aspect (e.g. f s becomes C-c C-s) but also the custom shortcuts (e.g. n t activates org-capture).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ergoemacs/ergoemacs-mode/issues/511, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD5VWXJLNYR63TNS4HH7ILUJ53ZDANCNFSM5HFTQQTQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

mattfidler commented 2 years ago

Should be fixed in d719e7e

TinaRussell commented 2 years ago

Thank you very much!

Two things: the first is, is it just me, or have the definitions of “\<apps> d” and “\<apps> f” been reversed? I think \<apps> d used to be unchorded C-x and \<apps> f used to be unchorded C-c, but it seems to be the opposite now.

The second thing is that I used to define new definitions for the apps key using ergoemacs-component and ergoemacs-theme:

    (ergoemacs-component tina-keys ()
      "Tina’s keys"
      (global-set-key (kbd "<apps> n w") 'eww)
      (global-set-key (kbd "<apps> j") 'org-journal-new-entry)
      (define-key lisp-mode-shared-map (kbd "<apps> ’") (lambda () (interactive) (hydra-lispy-x/body))))

    (ergoemacs-theme tina ()
      "Tina’s modified theme for ErgoEmacs"
      :based-on standard
      :components '(tina-keys))

    (ergoemacs-set-default 'ergoemacs-theme "tina")

I’m wondering, now that ergoemacs-component is gone, what’s the best way to do this? Should I simply use (ergoemacs-define-key ergoemacs-override-keymap… etc. for each definition? (In that case, do I need to be concerned with ergoemacs-mode-raw-term-keymap as well? What about adding definitions to specific maps, like lisp-mode-shared-map above, is that still possible?)

Thanks!

mattfidler commented 2 years ago

Hi @TinaRussell,

I have been putting the documentation below:

https://github.com/ergoemacs/ergoemacs-mode#changing-your-own-bindings

Right now,

(define-key lisp-mode-shared-map (kbd "<apps> ’") (lambda () (interactive) (hydra-lispy-x/body))

Needs to be worked out.

mattfidler commented 2 years ago

I verified the keys were backwards (no wonder I kept mistyping). I swapped them back.

mattfidler commented 2 years ago

Also this should work in ergoemacs-mode since <menu> ' is not bound to any keys in the ergoemacs-mode keymap.

(define-key lisp-mode-shared-map (kbd "<apps> ’") (lambda () (interactive) (hydra-lispy-x/body)))
mattfidler commented 2 years ago

I am assuming this works for you @TinaRussell. If not feel free to open another issue.