search

ergoplatform / eips

Ergo Improvement Proposals
64 stars 36 forks source link

EIP-0022 Auction Contract #39

Closed anon-real closed 2 years ago

anon-real commented 3 years ago

This EIP proposes the auction contract.

greenhat commented 3 years ago

I'm testing the contract at https://github.com/ergoplatform/sigma-rust/pull/390 and so far I found that we are missing box.bytes op. I'm going to implement it and see if anything else is missing (fail on deserialization). So far I've glanced through the contract and I think everything else we have implemented already.

greenhat commented 3 years ago

I implemented box.bytes and finished checking the contract. It should work now.
I merged my PR - https://github.com/ergoplatform/sigma-rust/pull/390

chriswill commented 3 years ago

I had an interation with @anon-real on Discord about this line: // R9: Auction info that is needed for UI/UX purposes - comma separated string encoded as Coll[Byte]: and he agreed that it would make more sense to represent this as json so we could have a collection of name/value pairs.

Just wanted to add this comment so that ideally the EIP could be updated before it was approved and merged.

I think this is important for NFT developers would want to create a collection of custom properties and later display them. Would also be value for displaying nfts in auctionhouse.

For an example, see the existing NFT id:3124c2d48a3ce19f69d92f71eb4cf0ab41cfec2515f636d06fdd916a22838581

anon-real commented 3 years ago

I had an interation with @anon-real on Discord about this line: // R9: Auction info that is needed for UI/UX purposes - comma separated string encoded as Coll[Byte]: and he agreed that it would make more sense to represent this as json so we could have a collection of name/value pairs.

Just wanted to add this comment so that ideally the EIP could be updated before it was approved and merged.

I think this is important for NFT developers would want to create a collection of custom properties and later display them. Would also be value for displaying nfts in auctionhouse.

For an example, see the existing NFT id:3124c2d48a3ce19f69d92f71eb4cf0ab41cfec2515f636d06fdd916a22838581

@chriswill I think you are mixing two separate things. R9 register for auction box has some information about the auction such as description. This is different from NFT data which is set when the NFT is issued. Anyway, json format makes more sense -- I've updated the PR to include this change.