search

ergoplatform / eips

Ergo Improvement Proposals
64 stars 36 forks source link

EIP-0025 Payment Request URI scheme #49

Closed MrStahlfelge closed 2 years ago

MrStahlfelge commented 2 years ago

This EIP defines a payment request URI scheme to enable users to easily make payments by simply clicking links on webpages or in e-mails.

In difference to Ergo Pay (EIP-0020), this URI scheme does not contain a prepared transaction that the wallet should sign or discard. Instead, it contains the data that the wallet application should use to fill its payment form. The user can change the details when needed. The wallet will build the transaction, so this scheme is easier to handle on static websites or in e-mails.

satsen commented 2 years ago

I believe that ergo: should be used instead of ergoplatform:. I know that ergo is a common word, which is why ergoplatform.org had to be used instead of ergo.org, but I highly doubt that the URI scheme name is used by anything else. Imagine using URLs like bitcoinplatform: or moneroplatform:, it's not nice at all.

satsen commented 2 years ago

I'm also unsure about the If the amount parameter is not specified, then the wallet MUST put a minimum amount of ERGs to the new box part. Being that loose is of no use and anybody who has sent tokens will already know this. Inexperienced users could also be confused if the wallet improperly represents that it is about to send some ERGs as well when the parameter is missing.

aslesarenko commented 2 years ago

@satsen Some ERGs have to be sent anyway, this is required by the protocol. So, what is your proposal, make ERGs amount a required parameter? Please suggest a formulation.

satsen commented 2 years ago

@aslesarenko No, it should not be required. For for example donations, it doesn't make sense to require the parameter. My proposal is that if a token amount is supplied, then the ERG amount is required.

MrStahlfelge commented 2 years ago

How should a wallet app react when a token is added in the URI, but no amount? It looks like the whole payment request should be treated as invalid and should be discarded then? This does not seem very user friendly, I would prefer to let the wallet app set the min amount automatically in that case. This behaviour was requested by users for manual added tokens as well, most were confused that they had to specify an ERG amount manually.

MrStahlfelge commented 2 years ago

I believe that ergo: should be used instead of ergoplatform:. I know that ergo is a common word, which is why ergoplatform.org had to be used instead of ergo.org, but I highly doubt that the URI scheme name is used by anything else. Imagine using URLs like bitcoinplatform: or moneroplatform:, it's not nice at all.

I think ergo is a bit too generic, and there is already a ergopay URI scheme prefix proposed. Let's see what the majority thinks or prefers here.

satsen commented 2 years ago

@MrStahlfelge You're not really going to generate ergo URIs that much for the average user to need this kind of looseness. A wallet program could either leave the amount field empty and require the user to enter an ERG amount or it could deny the URI (not good). I think the standard should be that ERG amount is required when there is a token amount, but of course not everyone will follow the standard and asking the user for the missing amount should be the method in my opinion.

satsen commented 2 years ago

@MrStahlfelge I don't know what ergopay is or why a project that is not ergo should affect what the URI scheme name will be.

satsen commented 2 years ago

Do you mind specifying what happens if there are 2 entries of the same token. I suspect and propose that the last one will be the valid one but it would be good to have it in the standard.

MrStahlfelge commented 2 years ago

@MrStahlfelge I don't know what ergopay is or why a project that is not ergo should affect what the URI scheme name will be.

See here