search

ergoplatform / eips

Ergo Improvement Proposals
64 stars 36 forks source link

EIP-0023. Let ballot token owner (R4 in ballot box) always spend the ballot box #94

Closed greenhat closed 1 year ago

greenhat commented 1 year ago

Following https://github.com/ergoplatform/eips/pull/41/files#r1243427074

Motivation

isSimpleCopy clause for owner requires minting new ballot tokens for ANY change to the update contract or its parameters (min_votes).

I forgot to mint new ballot tokens on changing the update contract and now those ballot tokens cannot be used. See https://github.com/ergoplatform/oracle-core/issues/291#issuecomment-1609089590 for details.

Rewriting the final clause as owner || (isSimpleCopy && update) would allow to keep using existing ballot tokens since voting is done by ballot owners (PK check).

scalahub commented 1 year ago

Approved