ergoplatform / sigmastate-interpreter

ErgoScript compiler and ErgoTree Interpreter implementation for Ergo blockchain
MIT License
63 stars 41 forks source link

[6.0] Global.serialize method #989

Closed aslesarenko closed 2 months ago

aslesarenko commented 6 months ago

In this PR:

aslesarenko commented 6 months ago
  • do serialize - deserialize roundtrip test

  • test newly supported data types , namely Header and Option[], explicitly , but better to test more , see BasicOpsSpecification in deserialize PR

Do you suggest to base this PR on top of #979?

kushti commented 6 months ago
  • do serialize - deserialize roundtrip test
  • test newly supported data types , namely Header and Option[], explicitly , but better to test more , see BasicOpsSpecification in deserialize PR

Do you suggest to base this PR on top of #979?

Sure, how else can you check the roundtrip . Also, new serializers (Header & Option) are there

aslesarenko commented 6 months ago

Do you suggest to base this PR on top of #979?

Sure, how else can you check the roundtrip . Also, new serializers (Header & Option) are there

Ok, then this can be postponed until:

kushti commented 6 months ago

Do you suggest to base this PR on top of #979?

Sure, how else can you check the roundtrip . Also, new serializers (Header & Option) are there

Ok, then this can be postponed until:

* [[6.0] Merge with refactored SigmaCompiler #987](https://github.com/ScorexFoundation/sigmastate-interpreter/pull/987) is merged

* [[6.0] Global.deserializeTo[] method #979](https://github.com/ScorexFoundation/sigmastate-interpreter/pull/979) is finalized and merged

There is no need to wait for merge of #979. Actually, this PR and #979 will be likely merged about the same time.

aslesarenko commented 6 months ago

There is no need to wait for merge of #979. Actually, this PR and #979 will be likely merged about the same time.

At least tests should be fixed in #979 before I can merge it into this PR. Also, #987 should be merged into #979.

kushti commented 5 months ago

TODO:

aslesarenko commented 5 months ago
  • check if a specific serializer w. costing possible / makes sense

Please clarify:

Also, please fix the tests.

kushti commented 5 months ago

@ergomorphic those are notes for myself, the PR is not finished, please review finished PRs! In particular, to fix the tests, https://github.com/ScorexFoundation/sigmastate-interpreter/pull/972 with Header serialization should be merged into v6.0.0 branch and then this PR.

aslesarenko commented 2 months ago

@kushti, LGTM, cannot approve my own PR, consider approved.