ergoserv / redmine-progressive-projects-list

⛏️ Redmine plugin that powers a project list with progress bars for every project and version.
https://ergoserv.github.io/redmine-progressive-projects-list/
MIT License
109 stars 57 forks source link

Added one issue,60% done - project progress bar still shows 0% #10

Closed tomyfranncy closed 11 years ago

tomyfranncy commented 11 years ago

Added one issue,60% done - project progress bar still shows 0%

version 0.10

stgeneral commented 11 years ago

Please, make sure you are using the latest version (0.1.0 at this time). It has a fix for similar issue #3. There was no release named 'version 0.10'.

Progressbar indicates overall active/done/closed-ratio based on the %-done and statuses of the issues, visualized by different colour-gradients. And percents near progress bar shows percent of closed issued. So, that's OK if you have project list like this: progressive-project-list-issue-10

tomyfranncy commented 11 years ago

Sorry,version 0.1.0 cannot display %done, project list like this: test5 thanks

stgeneral commented 11 years ago

That's ok. 0% - is for closed issues. Add one more issue with status 'closed' to any of your projects and you'll see the difference.

tomyfranncy commented 11 years ago

but you's project list have "project with 1 issue 60% done"

so what does it mean?

thanks

stgeneral commented 11 years ago

There are two projects:

cforce commented 11 years ago

tomyfranncy the lighter green shows percent done of issue(s), the dark green shows number of done issues in relation to absolute numvers of issues of version in percent.

tomyfranncy commented 11 years ago

thanks stgeneral&cforce ha,it's my fault

whether display %done for issue(s)[lighter green] ?

stgeneral commented 11 years ago

Yeah, @cforce thank you for help :)

whether display %done for issue(s)[lighter green] ?

Current progress bar behavior and look are part of Redmine's core. And I do see any reason to change them in the plugin, it will only cause confusion and maintainability problem.

Saylrman64 commented 9 years ago

Hello again,

What I was looking for (and maybe others are too) is specifically how the progress % is determined. Please correct me if I am wrong but in addition to the explination above I offer this: It looks like the Progress Bar (lighter color) is estimated by adding the % done for each issue and dividing by the number of issues. Issues that are in Closed status = 100% no matter what the % Done slider inside the Issue shows. This progress bar does not care about estimated time. The % field is estimated hours total divided by number of open tickets. See code snippet below for he % complete math.

It would seem the % complete should take into account the Estimated and Spent Hours. Is that also inherited from Redmine or is it only calculated in your project_decorator.rb?

Thanks again.

Code snippet from redmine-progressive-projects-list/lib/progressive/project_decorator.rb:

  # Cloned from Version#issues_progress(open)
  def issues_progress(open)
    @issues_progress ||= {}
    @issues_progress[open] ||= begin
      progress = 0
      if issues.count > 0
        ratio = open ? 'done_ratio' : 100

        done = issues.sum("COALESCE(CASE WHEN estimated_hours > 0 THEN estimated_hours ELSE NULL END, #{estimated_average}) * #{ratio}",
                                  :joins => :status,
                                  :conditions => ["#{IssueStatus.table_name}.is_closed = ?", !open]).to_f
        progress = done / (estimated_average * issues.count)
      end
      progress
    end
  end
stgeneral commented 9 years ago

@Saylrman64 as you can see the code for this calculations was cloned from the Redmine core. I believe that code and plugin should share the same behavior. So, if any change to this logic needs any update this update should be added to the Redmine core first.

Saylrman64 commented 9 years ago

Thank you @stgeneral If I wever get time or energy to make the estimation better, I will start with Redmine core.

Thanks again.

ahsankhan201 commented 9 years ago

@stgeneral can we also show the number of inprogress issues, and resolved issues?

stgeneral commented 9 years ago

@ahsankhan201 Redmine has two high level statuses: 'open' and 'closed'. Other statuses ('In progress', 'Resolved', etc) are custom and should not be tracked by generic plugin.

ahsankhan201 commented 9 years ago

@stgeneral Thanks for your reply. but tell me how can i achive it by customise your plugin. because i am a layman in redmine development.

stgeneral commented 9 years ago

@ahsankhan201 you may take a look and customize this lines:

ahsankhan201 commented 9 years ago

@stgeneral can you help me out to customise these lines. which argument i can add for getting in progress issues.?

stgeneral commented 9 years ago

@ahsankhan201 I have no plan to add this feature to the plugin. So, you may feel free to update plugin as you like.