ergoserv / redmine-progressive-projects-list

⛏️ Redmine plugin that powers a project list with progress bars for every project and version.
https://ergoserv.github.io/redmine-progressive-projects-list/
MIT License
109 stars 57 forks source link

ActionView::Template::Error #81

Closed mmxbow closed 4 years ago

mmxbow commented 6 years ago

Environment:

After installing the plugin i've got a error:


ActionView::Template::Error incomplete format specifier; use %% (double %) instead

I made a correction in the file lib/progressive/projects_helper_patch.rb:

the line 48:


s << progress_bar([project.issues_close_percent, project.issues_completed_percent], :width => '30em', :legend => '%0.0f%' % project.issues_closed_percent)

was replaced by:


s << progress_bar([project.issues_close_percent, project.issues_completed_percent], :width => '30em', :legend => '%0.0f%%' % project.issues_closed_percent)

The problem was gone.

mmxbow commented 6 years ago

I think the line 60 in the same file need to be corrected too: replace format '%0.0f%' by '%0.0f%%'

stgeneral commented 6 years ago

@mmxbow thanks for the report and attention to the plugin!

I suppose that issue is caused by Ruby 2.5.1. It seems that Redmine itself was not tested against the 2.5 (see http://www.redmine.org/projects/redmine/wiki/RedmineInstall).

These lines were copied from the Redmine's code. So, you might experience other issues with Redmine. Maybe you should consider downgrading Ruby to officially supported version 2.4.

kulombok commented 6 years ago

I have the same issue with the same ruby version 2.5.1 For now, would you like to tell me how to uninstall this plugin ? -> oh don't worry i have found the way to doit. I looking forward when its support to ruby 2.5 thx

stgeneral commented 6 years ago

I have the same issue with the same ruby version 2.5.1

Thanks for confirming.

I looking forward when its support to ruby 2.5 thx

Is your clean Redmine setup works well with Ruby 2.5?

stgeneral commented 4 years ago

Should be fixed by #84.