search

erh / mongo-munin

Munin plugins for MongoDB
144 stars 59 forks source link

fix for globalLock.ration value #8

Open michalekn opened 12 years ago

michalekn commented 12 years ago

Since mongo 2.2 there is no info in globalLock.ratio but it can be counted manually by dividing globalLock.lockTime and globalLock.totalTime. This fix doing it.

tianon commented 11 years ago

It would also be useful if it were to loop over the value of getServerStatus()["locks"] and give us a ratio for each one, since MongoDB now does database-level locking, and these values represent the lock time for each database separately.

jlecour commented 11 years ago

@tianon It's a detail, but he correct command is db.serverStatus()["locks"].

Otherwise, I get this : 

> db.getServerStatus()["locks"]
Thu Nov  8 17:38:10 TypeError: db.getServerStatus is not a function (shell):1
jlecour commented 11 years ago

My bad, I didn't see that the function was from the script, not from MongoDB itself.

Sorry for the n00b noise.

tianon commented 11 years ago

No worries; I had the exact same thought initially until I looked closer at the script.

On 8 November 2012 10:05, Jérémy Lecour notifications@github.com wrote:

My bad, I didn't see that the function was from the script, not from MongoDB itself.

Sorry for the n00b noise.

— Reply to this email directly or view it on GitHubhttps://github.com/erh/mongo-munin/pull/8#issuecomment-10195901.

jlecour commented 11 years ago

I've tried this patch, and I get a growing value, always > 1.0 which doesn't look like a percentage.