search

erhuabushuo / webrtc2sip

Automatically exported from code.google.com/p/webrtc2sip
0 stars 0 forks source link

RTCweb breaker includes invalid ice-pwd attribute in SDP #160

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Enable RTCweb breaker, make an audio call from SIPML5
2. Observe the SDP sent from webrtc2sip gateway to the core network
3.

What is the expected output? What do you see instead?
The ice-pwd attribute is invalid, because its length is 21 characters, not 
meeting the minimum length requirement set by RFC 5245 (at least 2 characters).
Example sent by the webrtc2sip GW:
a=ice-pwd:1rWRyRkaDGkJ0WoH1gRZR
(which is only 21 characters!)

What version of the product are you using? On what operating system?
webrtc2sip 2.5.0 on Ubuntu 12.04

Please provide server logs with DEBUG level equal to INFO

This is the whole Invite message sent by webrtc2sip Gateway:

INVITE sip:4682200038@tcexpo.ics.se SIP/2.0
Via: SIP/2.0/UDP 10.170.75.223:10060;branch=z9hG4bK257350198;rport
From: <sip:4682200036@tcexpo.ics.se>;tag=2066748770
To: <sip:4682200038@tcexpo.ics.se>
Contact: 
<sip:4682200036@10.170.75.223:10060;ws-src-ip=10.170.74.51;ws-src-port=56267;ws-
src-proto=ws;transport=udp>
Call-ID: 2172515a-3e12-6152-99be-57550357ad1c
CSeq: 1444621829 INVITE
Content-Type: application/sdp
Content-Length: 1035
Max-Forwards: 70
User-Agent: webrtc2sip Media Server 2.5.0

v=0
o=doubango 1983 678901 IN IP4 10.170.75.223
s=-
c=IN IP4 10.170.75.223
t=0 0
a=tcap:1 UDP/TLS/RTP/SAVPF UDP/TLS/RTP/SAVP RTP/SAVPF RTP/SAVP RTP/AVPF
m=audio 36158 RTP/AVP 8 0 101
c=IN IP4 10.170.75.223
a=ptime:20
a=minptime:20
a=maxptime:20
a=silenceSupp:off - - - -
a=rtpmap:8 PCMA/8000/1
a=rtpmap:0 PCMU/8000/1
a=rtpmap:101 telephone-event/8000/1
a=fmtp:101 0-16
a=acap:1 crypto:1 AES_CM_128_HMAC_SHA1_80 
inline:bJDes6AaPVCBb2YMLsElugmtcI+yBvI8EL7OiWSU
a=acap:2 crypto:2 AES_CM_128_HMAC_SHA1_32 
inline:gYP8RHyP60wgDUeQlMDNldwO/+8d5+qNcHWEPLf0
a=pcfg:1 t=1
a=pcfg:2 t=2
a=pcfg:3 t=3 a=1,2
a=pcfg:4 t=4 a=1,2
a=pcfg:5 t=5
a=sendrecv
a=rtcp-mux
a=ssrc:1386073364 cname:d5f75fd54bdbb2fce64609550609a7e7
a=ssrc:1386073364 mslabel:6994f7d1-6ce9-4fbd-acfd-84e5131ca2e2
a=ssrc:1386073364 label:doubango@audio
a=ice-ufrag:U4T6fbwPxs5Ct5E
a=ice-pwd:1rWRyRkaDGkJ0WoH1gRZR
a=candidate:a78Me6aWW 1 udp 2130706431 10.170.75.223 36158 typ host
a=candidate:a78Me6aWW 2 udp 2130706430 10.170.75.223 36159 typ host

Please provide browser logs

Original issue reported on code.google.com by Robin.Xi...@gmail.com on 5 Sep 2014 at 9:57

GoogleCodeExporter commented 9 years ago 
Btw, is there a way to turn off ICE on webrtc2sip gateway?  The desired 
behavior is for it to act as RTCweb breaker, which terminates ICE towards the 
client and does NOT use ICE towards the other side (legacy SIP core network).

Original comment by Robin.Xi...@gmail.com on 5 Sep 2014 at 9:59

GoogleCodeExporter commented 9 years ago

Original comment by boss...@yahoo.fr on 6 Sep 2014 at 6:18

GoogleCodeExporter commented 9 years ago 
You're using a very old version. This was fixed months ago: 
https://code.google.com/p/doubango/source/diff?path=/branches/2.0/doubango/tinyN
ET/src/ice/tnet_ice_utils.c&format=side&r=1035

Original comment by boss...@yahoo.fr on 8 Sep 2014 at 2:02