eric-bixby / auto-sort-bookmarks-webext

Firefox add-on to sort bookmarks by multiple criteria
GNU General Public License v3.0
112 stars 20 forks source link

Configure Folders: can not be saved #110

Closed jjaone closed 1 year ago

jjaone commented 1 year ago

Opening extensions Preferences there is in the bottom of window link to "Configure Folders" which opens a new tab to setup "Folders to Sort" which works as it should.

Problem is that there is no way to save the settings, only a button (x) in the top right corner which just closes the window/tap but the folder sort setup is not saved.

I'm on Linux/Ubuntu 20.04, Firefox 103.0 (64 bit) build:103.0+build1-0ubuntu0.20.04.

Screenshot from 2022-08-09 19-46-56

eric-bixby commented 1 year ago

First, there is no save button. Your changes take effect immediately and are saved automatically (you don't need to do anything). Second, when you say your config is not being saved, what do you mean? Are you assuming it's not because there is no save button? You should be able to close the browser and open it again and see your settings. Also, you can verify it works by manually moving a bookmark out of order, clicking on the "Sort" button, then confirming that it was not moved.

jjaone commented 1 year ago
  1. In GUI if user action open a form in new window/tab it should be able for user to close that view by cancel or ok (save) options. That's expected behavior by users of most of any application. So this is bad design of UI in Settings.

  2. The config is not fully saved ( see the two screenshots): First I unchecked two folders and their subfolders with the recursive box checked from being sorted automatically. Then closed that tab and also restarted browser, opened the auto-sort:settings:configure folders view again, and those two unchecked folders and their recursive box are back to initial setup. So, I was not assuming that the setup is not saved (e.g. because of the flawed UI design) but instead tested it i.e. made the change and checked whether it was saved or not.

  3. Also, checked the sorting of bookmarks which confirmed that those two folders are still auto-sorted. So the setup was not saved but it reverted to the original setup (which auto-sorts all folders).

First screenshot shows the made changes to config: Screenshot from 2022-08-10 04-45-49

Second screenshot (after closing the tab and restarted browser) shows that the config is back to original Screenshot from 2022-08-10 04-56-35

eric-bixby commented 1 year ago

There's no save button for technical reasons, not by design. Maybe if/when the "configure-folders" feature is overhauled, this can be addressed.

Anyway, it looks like Firefox/Mozilla has changed things (again). If you enter "about:config" in the address-bar, then search for "bouanto" (the original author).

If you see something like the following, then your preferences have been migrated by Firefox: extensions.webextensions.ExtensionStorageIDB.migrated.sortbookmarks@bouanto

Looks like Mozilla has changed the way preferences are stored, so that might be the issue. I need to do some reading/experiments to find out.

In the meantime, this support article from Mozilla might help: https://support.mozilla.org/en-US/kb/how-to-fix-preferences-wont-save

jjaone commented 1 year ago

What "technical" reasons? You didn't specify any!

BTW: checking the other open issues in this repo it appears that half of user reports are about this same bug "configure folders setting is not stored and/or reverts to original setting. "

Anyway, instead of blaming this bug on Mozilla or on users making these reports or on any other than yourself why don't you just fix your misbehaving plugin, or ask help from the community if you don't know how!

eric-bixby commented 1 year ago

If you read my response, I did not blame anyone. Sometimes the issue is Firefox or the user, but I did not say it definitely was.

I said I would look into it, but dealing with your arrogance makes this a complete waste of my time.

eric-bixby commented 1 year ago

Duplicate of #75