eric-bixby / auto-sort-bookmarks-webext

Firefox add-on to sort bookmarks by multiple criteria
GNU General Public License v3.0
112 stars 21 forks source link

Nothing gets sorted #20

Closed gene-pavlovsky closed 7 years ago

gene-pavlovsky commented 8 years ago

FF 40.0.2, I just noticed the auto-sort no longer works. I have auto sorting disabled and instead use the toolbar button to run this plug-in. When I do, nothing happens - the bookmark folders inside Bookmark menu (it's checked in "sort folders" list) don't get sorted. Nothing in the browser console.

antoyo commented 8 years ago

It works on my side. Do have you thousands of bookmarks? If yes, it can be at bit slower to sort them. Which version of the add-on do you use? Is it working with an older version? Thanks for reporting the issue.

gene-pavlovsky commented 8 years ago

I've got the 2.10 version of the add-on and over 2000 bookmarks. I just noticed a strange thing - if I mess up the sort order of the bookmark folders I've had before, then use the add-on, sort order is restored. However there are two new bookmark folders I've added just recently, they stay at the bottom of the bookmarks menu (right after recently bookmarked) - they don't get sorted. But strangely after I dragged them up somewhere, then sorted again, they got sorted. Why is that zone at the end of bookmarks menu excluded from sorting? Picture illustration attached, the "TODO" folder is the one not getting sorted, moving it above "most visited" manually then sorting and it works. --Gene

On 11 September 2015 at 19:39, antoyo notifications@github.com wrote:

It works on my side. Do have you thousands of bookmarks? If yes, it can be at bit slower to sort them. Which version of the add-on do you use? Is it working with an older version? Thanks for reporting the issue.

— Reply to this email directly or view it on GitHub https://github.com/antoyo/auto-sort-bookmarks/issues/20#issuecomment-139535488 .

antoyo commented 8 years ago

@gene-pavlovsky This is perfectly normal. Look at the option "Delay for Folders". This option exists to allow you to rename the folder before it gets sorted.

gene-pavlovsky commented 8 years ago

Delay is set to 30. 30 what? Can you explain what this option does, exactly?

On 17 September 2015 at 20:46, Gene Pavlovsky gene.pavlovsky@gmail.com wrote:

I've got the 2.10 version of the add-on and over 2000 bookmarks. I just noticed a strange thing - if I mess up the sort order of the bookmark folders I've had before, then use the add-on, sort order is restored. However there are two new bookmark folders I've added just recently, they stay at the bottom of the bookmarks menu (right after recently bookmarked) - they don't get sorted. But strangely after I dragged them up somewhere, then sorted again, they got sorted. Why is that zone at the end of bookmarks menu excluded from sorting? Picture illustration attached, the "TODO" folder is the one not getting sorted, moving it above "most visited" manually then sorting and it works. --Gene

On 11 September 2015 at 19:39, antoyo notifications@github.com wrote:

It works on my side. Do have you thousands of bookmarks? If yes, it can be at bit slower to sort them. Which version of the add-on do you use? Is it working with an older version? Thanks for reporting the issue.

— Reply to this email directly or view it on GitHub https://github.com/antoyo/auto-sort-bookmarks/issues/20#issuecomment-139535488 .

antoyo commented 8 years ago

This is 30 seconds. This means that the folders will be sorted after 30 seconds (so that you have the time to rename a folder after creating one; otherwise, you will create a new folder and it will get sorted before you have the time to do so). I suggest you to read the section About this Add-on on this page or the readme for more information.

gene-pavlovsky commented 8 years ago

Thank you. Appreciate your help. I still don't understand, why these folders only got sorted after I moved them up higher than "Most visited, Recent Tags, Recently bookmarked" ? (see screenshot 2 e-mails ago).

On 18 September 2015 at 19:34, antoyo notifications@github.com wrote:

This is 30 seconds. This means that the folders will be sorted after 30 seconds (so that you have the time to rename a folder after creating one; otherwise, you will create a new folder and it will get sorted before you have the time to do so). I suggest you to read the section About this Add-on on this page https://addons.mozilla.org/en-us/firefox/addon/auto-sort-bookmarks/ or the readme https://github.com/antoyo/auto-sort-bookmarks#readme for more information.

— Reply to this email directly or view it on GitHub https://github.com/antoyo/auto-sort-bookmarks/issues/20#issuecomment-141439704 .

eric-bixby commented 7 years ago

I think this issue is OBE (overcome by events). I'm not able to reproduce it. If you still see the same problem in the latest release (2.10.7), then open a new issue.