search

eric-bixby / auto-sort-bookmarks-webext

Firefox add-on to sort bookmarks by multiple criteria
GNU General Public License v3.0
112 stars 21 forks source link

Multiple bookmarks receive the same `position` index #31

Closed blackwind closed 6 years ago

blackwind commented 8 years ago

Took me a long time to figure this one out, but apparently this add-on doesn't correctly modify all necessary position indexes when sorting. Over time, you end up with multiple bookmarks sharing the same position, so although the sorting appears correct on the source device, when you use sync, your bookmarks end up completely jumbled on your other devices.

eric-bixby commented 8 years ago

If the sort is running while you are adding/importing/syncing (or any activity that changes the indexes), then I can see this happening. I'll run some experiments with sync, xmarks, and eversync.

michaelalandover commented 8 years ago

I was not aware of sync or eversync. I’m checking our Eversync. I have repeatedly asked Xmarks to add sorting but they are too big go bother (they were bought by LastPass). Wouldn’t it be ideal to have your code integrated with one of these products?

eric-bixby commented 8 years ago

@michaelalandover: you, me, and a lot of other people have asked xmarks/LastPass to add a sort feature repeatedly for many years. Sadly, it's never going to happen.

I used to use xmarks, now I like EverSync (it doesn't sort either); it has a free iPhone app and I can sync with Chrome: https://addons.mozilla.org/en-US/firefox/addon/fvd-synchronizer

Anyway, I think ASB should be sync-client neutral (I don't think any integration is needed).

When the new release (2.10.6) is available, give it a try and let me know if it's more stable or not.

michaelalandover commented 8 years ago

Cool, thanks for explaining. I might try EverSync.

eric-bixby commented 7 years ago

@blackwind: how can I replicate this? I noticed you said "sync". Are you using Firefox Sync? Are you syncing and sorting at the same time?

blackwind commented 7 years ago

Are you using Firefox Sync?

Correct.

Are you syncing and sorting at the same time?

Am I explicitly running a sync and a sort at the same time? No. Is it possible I added a bookmark during a sync (which occurs in the background whenever it feels like it), causing the add-on to automatically sort my bookmarks at the same time? I suppose so.

Unfortunately, I can't provide any further insight as to how to reproduce, as reordering my thousands of bookmarks after the add-on jumbles them takes hours and hours of time I don't currently have to waste. All I can say for certain is, it happened, and I won't touch the add-on again until such a time that this is confirmed to be resolved.

eric-bixby commented 7 years ago

I understand your frustration. I spend many hours curating my bookmarks and losing them and/or having to fix them is a pain.

In addition to preventing (if possible) such corruption, I'm thinking of adding a new feature to automatically/manually recover such a corruption. If the bookmarks are completely unreadable by Firefox, then it will need to be a standalone tool.

eric-bixby commented 6 years ago

I'm closing this because I'm not able to reproduce the problem reported.