search

eric-bixby / auto-sort-bookmarks-webext

Firefox add-on to sort bookmarks by multiple criteria
GNU General Public License v3.0
113 stars 21 forks source link

Black Icon Not Seen on Black Background #33

Closed eric-bixby closed 7 years ago

eric-bixby commented 8 years ago

I had changed the icon color from gray/grey to black, which is fine for a light colored background, but not good for a dark colored background. I'd like the icon to change like the Firefox toolbar icons which automatically adjust from black to white based on the background color. I couldn't find the documentation for this feature. If anyone knows, please let me know.

In the meantime, I was thinking of doing a circular or rectangular filled area of red, white, or blue.

Gitoffthelawn commented 8 years ago

Or restore the gray icon. :)

The gray icon matched all the other native icons when it was placed in Firefox's menu panel. Unfortunately, the black icon doesn't match any of the browser's native icons.

eric-bixby commented 8 years ago

It might depend on your platform/monitor, but for me, and report by others, the gray icon is too light and looks like a disabled icon.

Gitoffthelawn commented 8 years ago

I agree. The default gray icons chosen by Mozilla are all very light. I think they were trying to make them blend into the background to be less intrusive. But when one icon is dark (how Auto-Sort Bookmarks is now) and the others are light, it makes it look like all the others are disabled.

It's an odd UI/UX conundrum Mozilla has created.

Here's a possible solution: When Auto-Sort Bookmarks is in auto mode, use a high contrast icon, and when it is manual mode, use the gray icon.

eric-bixby commented 8 years ago

I'm thinking something like the following... icon-16 icon-32 icon-64

I'd like to use a different color for manual vs. automatic sorting mode and maybe one more color when the sorting is in progress.

Gitoffthelawn commented 8 years ago

I'd like to use a different color for manual vs. automatic sorting mode and maybe one more color when the sorting is in progress.

:+1:

I wish I had the time right now, but I'd like to make a new icon altogether. The arrow icon is too similar to the native Firefox download icon. I do at like the big arrow more than the all-too-common "A...Z" icons that aren't really appealing for this extension.

digitalcircuit commented 8 years ago

If there's no way to tap into background-color dependent icons like Firefox does, I'd suggest an icon that's more "flat" instead of glossy or highlighted, since that seems more out of place next to the other icons.

Here's a screenshot with an example of a few other icons, though these aren't perfect either :) firefox - auto sort bookmarks all icons on linux

It might also work to add a preference for choosing an icon style (colored, light, dark).

eric-bixby commented 8 years ago

Unfortunately, it will never be perfect because everyone has different tastes. That's why I'd prefer to keep it as simple and neutral as possible. I'll probably just update the color/colour (US/UK) to more closely match the default Firefox style.

Meanwhile, I will keep searching the Mozilla SDK, there must be a way of detecting the theme background color, then I can pragmatically change the icon used.

eric-bixby commented 7 years ago

Version 3.0 has a new icon.