eric-bixby / auto-sort-bookmarks-webext

Firefox add-on to sort bookmarks by multiple criteria
GNU General Public License v3.0
113 stars 21 forks source link

Auto-Sort no longer working #4

Closed frasej closed 9 years ago

frasej commented 10 years ago

I don't know what has changed, but Auto-Sort Bookmarks no longer automatically sorts. I'll drop a new bookmark in and it just sits there.

antoyo commented 10 years ago

This bug has been fixed in commit 0231bc895c634d1e5a9aa17013327cf06f05961e. The fix will be in the next version of the add-on. Thanks for reporting it.

frasej commented 9 years ago

If this was to be fixed in v2.4, I'm still having the problem. Interestingly, if I disable the extension and the re-enable it, auto-sort will do an initial sort of all the bookmarks, but does nothing after that.

antoyo commented 9 years ago

Can you post the errors from the browser console (Ctrl-Shift-J) please?

frasej commented 9 years ago

"DEPRECATED: The widget module is deprecated. Please consider using the sdk/ui module instead.

Traceback (most recent call last):

File "resource://gre/modules/services-sync/service.js", line 1595, in null

Service.onStartup();

File "resource://gre/modules/services-sync/service.js", line 318, in onStartup

if (!Status || !Status._authManager) {

File "resource://services-sync/status.js", line 36, in this.Status._authManager

cb.wait();

File "resource://services-common/async.js", line 145, in makeSpinningCallback/callback.wait

callback.wait = function() Async.waitForSyncCallback(cb);

File "resource://services-common/async.js", line 102, in waitForSyncCallback

thread.processNextEvent(true);

File "resource://gre/modules/Promise-backend.js", line 745, in this.PromiseWalker.walkerLoop

this.handlers.shift().process();

File "resource://gre/modules/Promise-backend.js", line 866, in Handler.prototype.process

nextValue = this.onResolve.call(undefined, nextValue);

File "resource://gre/modules/commonjs/sdk/addon/runner.js", line 115, in startup/<

run(options);

File "resource://gre/modules/commonjs/sdk/addon/runner.js", line 172, in run

let program = main(options.loader, options.main);

File "resource://gre/modules/commonjs/toolkit/loader.js", line 659, in main

return loader.load(loader, module).exports;

File "resource://gre/modules/commonjs/sdk/loader/cuddlefish.js", line 129, in CuddlefishLoader/options<.load

result = load(loader, module);

File "resource://gre/modules/commonjs/toolkit/loader.js", line 313, in load

evaluate(sandbox, module.uri);

File "resource://gre/modules/commonjs/toolkit/loader.js", line 262, in evaluate

: loadSubScript(uri, sandbox, encoding);

File "resource://jid0-k75tfrgfoxphfezmj9cku5ecglc-at-jetpack/translate-this/lib/main.js", line 5, in null

var widget = require("sdk/widget");

File "resource://gre/modules/commonjs/toolkit/loader.js", line 633, in require

freeze(load(loader, module));

File "resource://gre/modules/commonjs/sdk/loader/cuddlefish.js", line 129, in CuddlefishLoader/options<.load

result = load(loader, module);

File "resource://gre/modules/commonjs/toolkit/loader.js", line 313, in load

evaluate(sandbox, module.uri);

File "resource://gre/modules/commonjs/toolkit/loader.js", line 262, in evaluate

: loadSubScript(uri, sandbox, encoding);

File "resource://gre/modules/commonjs/sdk/widget.js", line 59, in null

require("./util/deprecate").deprecateUsage(

File "resource://gre/modules/commonjs/sdk/util/deprecate.js", line 18, in deprecateUsage

let stack = get().slice(2);" deprecate.js:21

TypeError: c is undefined

Stack trace:

at@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/admin/AppData/Roaming/Mozilla/Firefox/Profiles/lnq2zkc5.default/extensions/YouTubeSmartPause@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://jid0-hd39bgk3euibk47rgw3fzdr163o-at-jetpack/image-resizer/data/jquery-2.0.0.min.js:4:8680

@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/admin/AppData/Roaming/Mozilla/Firefox/Profiles/lnq2zkc5.default/extensions/YouTubeSmartPause@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://jid0-hd39bgk3euibk47rgw3fzdr163o-at-jetpack/image-resizer/data/jquery-2.0.0.min.js:4:23863

@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/admin/AppData/Roaming/Mozilla/Firefox/Profiles/lnq2zkc5.default/extensions/YouTubeSmartPause@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://jid0-hd39bgk3euibk47rgw3fzdr163o-at-jetpack/image-resizer/data/jquery-2.0.0.min.js:4:6566

@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/admin/AppData/Roaming/Mozilla/Firefox/Profiles/lnq2zkc5.default/extensions/YouTubeSmartPause@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://jid0-hd39bgk3euibk47rgw3fzdr163o-at-jetpack/image-resizer/data/jquery-2.0.0.min.js:4:1

core.js:90

ReferenceError: $ is not defined

Stack trace:

@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/admin/AppData/Roaming/Mozilla/Firefox/Profiles/lnq2zkc5.default/extensions/YouTubeSmartPause@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://jid0-hd39bgk3euibk47rgw3fzdr163o-at-jetpack/image-resizer/data/imageResizer.js:466:1

core.js:90

TypeError: folder.children[i][j] is undefined

Stack trace:

BookmarkSorter<.sortFolder@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/admin/AppData/Roaming/Mozilla/Firefox/Profiles/lnq2zkc5.default/extensions/YouTubeSmartPause@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://sortbookmarks-at-bouanto/autosortbookmarks/lib/bookmark-sorter.js:161:17

BookmarkSorter<.sortAndSave@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/admin/AppData/Roaming/Mozilla/Firefox/Profiles/lnq2zkc5.default/extensions/YouTubeSmartPause@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://sortbookmarks-at-bouanto/autosortbookmarks/lib/bookmark-sorter.js:138:13

BookmarkSorter<.sortFolders/this.thread<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/admin/AppData/Roaming/Mozilla/Firefox/Profiles/lnq2zkc5.default/extensions/YouTubeSmartPause@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://sortbookmarks-at-bouanto/autosortbookmarks/lib/bookmark-sorter.js:195:25

Thread<.execute@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/admin/AppData/Roaming/Mozilla/Firefox/Profiles/lnq2zkc5.default/extensions/YouTubeSmartPause@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://sortbookmarks-at-bouanto/autosortbookmarks/lib/thread.js:35:44

Thread<.execute/<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/admin/AppData/Roaming/Mozilla/Firefox/Profiles/lnq2zkc5.default/extensions/YouTubeSmartPause@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://sortbookmarks-at-bouanto/autosortbookmarks/lib/thread.js:37:17

notify@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/timers.js:40:9

waitForSyncCallback@resource://services-common/async.js:102:7

makeSpinningCallback/callback.wait@resource://services-common/async.js:145:32

this.Status._authManager@resource://services-sync/status.js:36:5

onStartup@resource://gre/modules/services-sync/service.js:318:20

@resource://gre/modules/services-sync/service.js:1595:1

TSTWH_overrideExtensionsDelayed@chrome://tabmixplus/content/changecode.js line 1 > eval:219:4

TSTWH_overrideExtensionsAfterBrowserInit/<@chrome://tabmixplus/content/changecode.js line 1 > eval:771:3

timers.js:43

From: antoyo [mailto:notifications@github.com] Sent: Tuesday, October 28, 2014 5:55 AM To: antoyo/auto-sort-bookmarks Cc: Jay Frase Subject: Re: [auto-sort-bookmarks] Auto-Sort no longer working (#4)

Can you post the errors from the console log (Ctrl-Shift-J) please?

— Reply to this email directly or view it on GitHub https://github.com/antoyo/auto-sort-bookmarks/issues/4#issuecomment-60750250 . https://github.com/notifications/beacon/AFYUtZNksvxW1lNKWb2z-hPC8S-GvuCIks5nH4mXgaJpZM4CutCJ.gif

antoyo commented 9 years ago

Please try version 2.5 to see if it fixed this issue.

frasej commented 9 years ago

I will have to do more test, but it appears to be working. Thank you.

From: antoyo [mailto:notifications@github.com] Sent: Thursday, October 30, 2014 2:18 PM To: antoyo/auto-sort-bookmarks Cc: Jay Frase Subject: Re: [auto-sort-bookmarks] Auto-Sort no longer working (#4)

Please try version 2.5 to see if it fixed this issue.

— Reply to this email directly or view it on GitHub https://github.com/antoyo/auto-sort-bookmarks/issues/4#issuecomment-61171193 . https://github.com/notifications/beacon/AFYUtYJ-kiJz8n832io61JZum6wvDncSks5nIqKOgaJpZM4CutCJ.gif