search

eric-bixby / auto-sort-bookmarks-webext

Firefox add-on to sort bookmarks by multiple criteria
GNU General Public License v3.0
112 stars 21 forks source link

Browser crash on startup #44

Closed mattsplats closed 7 years ago

mattsplats commented 7 years ago

Just today my Firefox is crashing on startup every time. After loading in Safe Mode and enabling addons one-by-one, I have found Auto-Sort to be the culprit. When enabled, Firefox crashes on startup; disabled, all is normal. In fact, just clicking Enable causes Firefox to crash instantly! I have not had issues in the past and have had auto-sort enabled.

Many thanks for this great add-on, I'll be glad to provide any assistance diagnosing this that I can (crash logs, etc.). I was looking through recent commits to master and the only changes I see are for localization - is it just me or does that sound like an unlikely culprit?

defmonk0 commented 7 years ago

Having the same issue as of today. As Matt said, if any assistance is needed for diagnosis, let me know what you need.

eric-bixby commented 7 years ago

If someone could post a Mozilla Crash Report that would help with my analysis.

eric-bixby commented 7 years ago

I ran it on FF 51.0.1 on Mac, Win7, and Win10, but no crash. I cannot tell from the report where it is actually crashing. I would expect to see a crash address and reason as describe on this page: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/Crash_reporting/Understanding_crash_reports

eric-bixby commented 7 years ago

@mattsplats: Could you send me the raw dump? Do an "about:crashes", select the crash, click on the "raw dump" (you'll need to be signed-in), download the report and then email it to me directly: ebixby@yahoo.com

Taurean75 commented 7 years ago

I'm having the same problem. I'll send you a raw dump.

ivysrono commented 7 years ago

https://crash-stats.mozilla.com/report/index/2e61788f-5f36-4a6e-a731-007b22170220 @eric-bixby I'm Chinese.

Riajyuu commented 7 years ago

I'm so sorry. I shall be responsible for such crash. It seems that @ivysrono crash led by processing zh-CN locale file, which is submitted by me. @ivysrono , could you try to install this addon from English AMO (try English version of this addon) to see if crash happens again?

ivysrono commented 7 years ago

@EMLVIRUS https://crash-stats.mozilla.com/report/index/36e4017c-5b49-4477-9929-be95e2170220 I have changed my firefox to en-US and reinstalled autosort addon.

eric-bixby commented 7 years ago

@EMLVIRUS: I don't know that it's the Chinese translation yet.

I did a diff between release 2.10.9 and 2.10.10; there were other changes that I had made and forgot about. I did some code reformatting to fix some ESLint findings (a JavaScript format checker).

Could someone please try creating a new Firefox profile and re-installing the add-on? Maybe your old preferences are not compatible with the new release.

I'm still trying to reproduce the crash on my machines. Based on the provided crash reports, it seems to be a combination of the internationalization component and reading preferences.

Riajyuu commented 7 years ago

Em, I don't know what you have done. pull request #43 is only add a Chinese translate file. but @ivysrono seems to be more complex than I thought

ivysrono commented 7 years ago

Strange. I create a new profile and install the addon, No Crash...

eric-bixby commented 7 years ago

Great. It might seem strange, but that's what I was counting on. That means the problem is in the code I changed for preference handling. I wasn't crashing because I'm using the default settings.

yrdjuret commented 7 years ago

Do you want more crash reports?

eric-bixby commented 7 years ago

No thanks. I have enough crash reports.

I'll post a test version as soon as I have a fix.

eric-bixby commented 7 years ago

I'm able to reproduce the bug. It's the "then-sort-by" preference. The data-type got changed from integer to string. If you changed this preference, prior to upgrading to 2.10.10, then Firefox crashes on startup with 2.10.10 installed.

eric-bixby commented 7 years ago

I have a fix, if anyone wants to try using an unsigned release: https://github.com/antoyo/auto-sort-bookmarks/releases/tag/v2.10.11

To test this, here's my recommended test procedure: 1) Uninstall the existing version 2) Enter "about:config", then filter on "extensions.sortbookmarks@bouanto" 3) Right-click on each remaining pref or just then_sort_by and select "reset" 4) Restart Firefox (this will remove the add-on's default preferences) 5) Enter "about:debugging", then load v2.10.11 .xpi (using link above) 6) Enter "about:config", then filter on "extensions.sortbookmarks@bouanto" 7) Verify that then_sort_by has a type of Integer and a value of -1.

I also update the code so that if the type is still a String, it will convert the value to an integer.

Taurean75 commented 7 years ago

How do you install an unveiled add-on?

eric-bixby commented 7 years ago
  1. Enter "about:debugging" into the address bar.
  2. Select "Load Temporary Add-on" button.
  3. Browse to .xpi file and select "Open" button.
Taurean75 commented 7 years ago

Thanks,, Eric.

No crashes with the new version, although I couldn't test it by restarting.