Closed shangles closed 6 years ago
Yes, that's the plan.
Thank you for the speedy response. Again, great work on getting this handy add-on working in v57!
I badly need this also.
Yeah now my bookmarks are all screwed up! I had to disable this addon since last update broke ignore bookmarks!
I agree with @molitar. It would have been nice if the new version was launched WITH this feature already implemented. This had the consequence that now the bookmarks of the bookmarks toolbar are messed up.
@AntonioRedondo & @molitar, I believe you can restore your bookmarks within the bookmark library.
I was lucky my weekly backup just happened the night before so I just overwrote my browser local and roaming folder and than started in safe mode and disabled this app.
Status Update For those anxiously waiting for the exclude folders feature, I want to let you know the situation.
First, some background. The way this feature worked in ASB 2.X was to add a tag (also called annotation) of "excluded" and/or "resurivelyExcluded" to the folder. The advantage to this approach is that the tags are part of your bookmarks so it can be synced with other computers.
The bad news is that WebExtensions does not and will likely never support tags/annotations. Chrome doesn't have descriptions and it doesn't have tags/annotations. Having the ability to add descriptions to bookmarks is why I liked Firefox over Chrome.
[rant] It pisses me off that Mozilla decided to implement WebExtensions. You can't drop a Firefox add-on (using WebExtension) into Chrome and vice versa. They are similar but different. It is complete and utter marketing bullshit to imply that your life will be better with WebExtensions. [/rant]
Here's a Firefox bug for this issue (it's long and disappointing to read): https://bugzilla.mozilla.org/show_bug.cgi?id=1225916
The good news is that I'm trying to workaround this limitation. I'm planning to store the excluded folder settings with the other settings. However, there are a couple of obstacles I need to work out: 1) Settings/preferences do not currently sync between computers (assuming you have more than one). 2) Need to decide what to use as the key for each exclusion. I could use the folder 'id', which is fine for the root folders (menu-folder, toolbar-folder, other-folder) because they have set ids. However, ids for folders may vary between computers, even if you use a bookmark sync tool. I could use the folder title instead, but this may not be unique (you can have different sub-folders with the same title).
Thank you for the update!
I could use the folder title instead, but this may not be unique...
@eric-bixby, I'd suggest using full path names for this; e.g., "Bookmarks Toolbar\Live". This way, it'd be unique enough.
Yes, I thought of this too. The disadvantage to this is that if a folder is moved or renamed, then the user must update the exclusion. I could have the addon listen for the folder move/rename event to automatically update the exclusion, but this only works if the addon is running when the change happens. Otherwise it’s a manual change. Whereas this isn’t a problem if the ID is used.
@eric-bixby, just forget about the sync for now and use the IDs.
I thought of another option. Add a prefix or postfix to the folder title. That way it would be synced with the bookmarks. The root folders would just be by id and the user could select with check-boxes. While, the user folder would have the prefix or postfix. Like "NS-My Folder" (no sort) and "RNS-My Folder" (recursively no sort) or "My Folder-NS" and "My Folder-RNS". Also, let the user decide what the prefix or postfix text is.
Thoughts?
@eric-bixby, how about using the description field?
I can't. Tags and Description are not supported by WebExtensions.
I'm going to provide the option of using the folder id and/or folder title to exclude folders.
Pardon my ignorance, but do your suggestions involve me (us) modifying every one of our bookmark folders to add a prefix somewhere?
@shangles, just the folders.
Yes, that's what I asked. So if, in my bookmark library, I have 50+ folders to organize bookmarks, I'll need to update each of those?
Either the add-on could add/remove the folder or the user could do it manually. However, if the 50+ folders are under the same parent folder, like say Toolbar, then you would just recursively exclude the Toolbar folders (single action) and the child folders would also be excluded. Whereas, if the folders under the parent folder are mixed (some excluded and others not) then you have to individually mark the ones to exclude.
Ahh OK. That makes sense. So in my case it would just be on the Bookmark Toolbar folder that I'd want to exclude. Thanks for the explanation.
yeah Bookmark Toolbar is all I want to exclude also. I like everything else sorted but the toolbar I have the icons in order I use them in most often.
Here's a beta release to try: https://github.com/eric-bixby/auto-sort-bookmarks-webext/releases/tag/v3.2beta1
1) Backup your bookmarks. 2) Install add-on by entering "about:debugging" into addressbar. 3) Select "Load Temp Add-on" 4) Select the .xpi file downloaded using the URL given above.
It works great and seems faster!
I installed the latest beta and unchecked Bookmark Toolbar in the Configure Folders section and saved my changes. I also checked the Auto-Sort box (and saved changes)
I added a new bookmark but it's not auto-sorting. If I look at the Options for Configure Folders, the "recursive" box next to Bookmarks Menu is unchecked and grayed out so I can't check it. I'm assuming that's why it's not sorting the new bookmark automatically in one of the subfolders?
Ignore that. I went back and fumbled with some of the checkboxes and repeated my steps, and the new bookmark is now sorting as expected.
Glad you figured it out. FYI for everyone else.
The "Configure Folders" feature works exactly like it did for ASB 2.x. Changes are immediate, so you don't need to click a "save" button. Use the "+" to expand the child folders and "-" to collapse the children folders. All folders are included by default which is indicated by a checked checkbox. Some people might think the checkbox is to exclude folders but it's actually to include (checked=included, unchecked=excluded). The "recursive" checkbox is only enabled when a folder is excluded (unchecked).
There might be a bug with excluded child folders that I'm currently testing. If a parent is excluded, but not recursively, and some child folders are excluded and some included, then I think the children folder are all being excluded.
@eric-bixby, you should put the instructions on that page before releasing the next version.
Any idea why after installing the beta it keeps disappearing from my list of installed add-ons? ETA on a non-beta version that includes the folder exclusions?
Yes, that is how "Load Temporary Add-on" works; It's loaded until you restart Firefox. Anyway, probably a couple more days.
v3.2 is out and it resolves this issue. I say this can be marked as resolved now. Great work and have a happy new year!
@eric-bixby Do I need to do anything to change the status from Pending?
I do that part, thanks. I've changed it.
I'm reopening this because today I noticed my bookmarks in the Bookmarks Toolbar folder were alphabetized, rather than sorted manually. I immediately looked at my ASB settings and the Bookmarks Toolbar folder was still unchecked. Not sure what caused it to revert and sort the bookmarks in that folder.
I did recently open up Firefox on two other computers in the house (one Mac, one Linux) that are synced with my Firefox Sync account and verified that they were all configured the same.
I'm on 57.0.4 (64-bit) on Windows, mainly, and running version 3.2 of ASB.
If the checkbox for the Toolbar folder were checked, then I would think it was your preferences being cleared. I suspect Firefox-Sync might have something to do with it. It might take me a while to reproduce this problem.
Try the 3.3 beta 2 release. This addresses the issue of settings being lost due to cookies being removed. https://github.com/eric-bixby/auto-sort-bookmarks-webext/releases/tag/v3.3beta2
Thank you Eric. How soon until this makes it to the store for auto-updating?
Fixed in version 3.3, which is now available.
There was an option in the pre-v57 Firefox add-on to ignore the Bookmark Toolbar, which I always had enabled. I just installed your latest for v57 (THANK YOU!) but noticed in the options that there wasn't a setting for this. Is that coming in a future release?