eric-bixby / auto-sort-bookmarks-webext

Firefox add-on to sort bookmarks by multiple criteria
GNU General Public License v3.0
113 stars 21 forks source link

Translation not saved across sessions, Export button not working #68

Closed MeiGuddet closed 6 years ago

MeiGuddet commented 6 years ago

I made my translation to German and saved it, but after FF restart all is gone. Also it isn't possible to export the settings/translation, because the button doesn't work (no reaction when clicking on it). However Import button is working.

eric-bixby commented 6 years ago

FYI... when I click on the Export button, I see the following error in the console:

TypeError: _weh.browser.downloads is undefined 2 translation.js:23401:5 _export/< moz-extension://f4bf4ab6-85e6-a34f-9c1c-3889c8aa0361/content/translation.js:23401:5 callCallback moz-extension://f4bf4ab6-85e6-a34f-9c1c-3889c8aa0361/content/translation.js:5446:9 invokeGuardedCallbackDev moz-extension://f4bf4ab6-85e6-a34f-9c1c-3889c8aa0361/content/translation.js:5485:7 invokeGuardedCallback moz-extension://f4bf4ab6-85e6-a34f-9c1c-3889c8aa0361/content/translation.js:5342:5 invokeGuardedCallbackAndCatchFirstError moz-extension://f4bf4ab6-85e6-a34f-9c1c-3889c8aa0361/content/translation.js:5356:5 executeDispatch moz-extension://f4bf4ab6-85e6-a34f-9c1c-3889c8aa0361/content/translation.js:5740:3 executeDispatchesInOrder moz-extension://f4bf4ab6-85e6-a34f-9c1c-3889c8aa0361/content/translation.js:5762:5 executeDispatchesAndRelease moz-extension://f4bf4ab6-85e6-a34f-9c1c-3889c8aa0361/content/translation.js:5860:5 executeDispatchesAndReleaseTopLevel moz-extension://f4bf4ab6-85e6-a34f-9c1c-3889c8aa0361/content/translation.js:5871:10 forEach self-hosted:268:13 forEachAccumulated moz-extension://f4bf4ab6-85e6-a34f-9c1c-3889c8aa0361/content/translation.js:5839:5 processEventQueue moz-extension://f4bf4ab6-85e6-a34f-9c1c-3889c8aa0361/content/translation.js:6016:5 runEventQueueInBatch moz-extension://f4bf4ab6-85e6-a34f-9c1c-3889c8aa0361/content/translation.js:8511:3 handleTopLevel moz-extension://f4bf4ab6-85e6-a34f-9c1c-3889c8aa0361/content/translation.js:8520:3 handleTopLevelImpl moz-extension://f4bf4ab6-85e6-a34f-9c1c-3889c8aa0361/content/translation.js:8251:5 batchedUpdates moz-extension://f4bf4ab6-85e6-a34f-9c1c-3889c8aa0361/content/translation.js:15986:14 batchedUpdates moz-extension://f4bf4ab6-85e6-a34f-9c1c-3889c8aa0361/content/translation.js:7234:12 dispatchEvent moz-extension://f4bf4ab6-85e6-a34f-9c1c-3889c8aa0361/content/translation.js:8325:5 dispatchEvent self-hosted:1030:17

eric-bixby commented 6 years ago

I have a fix for this. Just need to add "downloads" to the requested permissions for the add-on.

eric-bixby commented 6 years ago

Export button fixed in version 3.3.2.