eric-bixby / auto-sort-bookmarks-webext

Firefox add-on to sort bookmarks by multiple criteria
GNU General Public License v3.0
112 stars 20 forks source link

3.3 is Completely Ignoring Configured Folders and Resetting and Messing up Bookmarks #82

Closed GuardianMajor closed 1 year ago

GuardianMajor commented 6 years ago

Upgraded to 3.3 with great hopes only to have it completely reset the configured folders and sort everything that it wasn't supposed to and mess up very carefully organized toolbar and menu.

I keep changing it back to what it should be and the minute the options window is closed, it resets back to the default, this is not cool at all, fixing one problem only to screw up something else, so disappointed.

(what it should be) image

(what it keeps resetting back to) image

it seems every time you check "auto sort" and then save the configuration it resets this, whether you are enabling it, or disabling it.

(enabled and it reset configured folders) image

This is so dumb.

eric-bixby commented 6 years ago

I just tried it and I'm not seeing that problem. Anyone else able to replicate the issue?

I know you said you open, then close the options tab, but are you doing the same for "configure folders" or is it happening while you leave it open?

GuardianMajor commented 6 years ago

Steps to reproduce it each and every time.

  1. Options
  2. Configure folders
  3. Close
  4. Check autosort
  5. Save
  6. Close
  7. Options
  8. Check folders (still there)
  9. uncheck autosort
  10. Save
  11. Close
  12. Options
  13. Configure folders (all gone)

Do you see it now?

shangles commented 6 years ago

I am back to having the issue of it sorting the bookmark toolbar alphabetically even though I told it to exclude.

After upgrading to 3.3 I noticed the checkbox to sort that folder was checked again. I unchecked it and manually sorted the toolbar how I liked it.

I just checked this morning and it's back to being sorted alphabetically, and the exclusion to ignore the toolbar is still unchecked (as it should be.)

eric-bixby commented 6 years ago

@GuardianMajor I'm still not seeing it. I'll try a different machine. I'm using FF 60.0.2, on a Mac, so I'll try your steps on Windows and Linux. Also, it might be a timing issue; try waiting a bit between each step and see if it makes a difference.

@shangles I should have mentioned that after upgrading, your settings/folders will be the default (no auto-sort, all folders enabled), so you'll need to reset your folders, then re-enable auto-sort.

GuardianMajor commented 6 years ago

I don't know how it would be a timing issue, the save should be instant and on top of that there is plenty of wait time for it to get there, so it shouldn't be an issue. It is happening without fail, so I don't know how you can't reproduce it, perhaps you are using a system that somehow works, but it is not here and it is on a clean profile, so there is nothing else that would interfere. Literally nothing. Try it on a Fx 56, maybe it is something that is not accounting for that, it is also happening on the ESR, so it might be something you are not accounting for in older versions of Firefox.

eric-bixby commented 6 years ago

Yes, this is a Firefox version specific problem. I just ran it on FF ESR 52 and saw the problem.

shangles commented 6 years ago

I'm on Firefox 60.0.2 (64-bit) in Windows 10, and after uninstalling and reinstalling the add-on, it's back to alphabetically sorting the bookmarks toolbar menu again.

GuardianMajor commented 6 years ago

@eric-bixby Great, glad you spotted it. Please let me know when you have a fix for it so I can reinstall and try it again, thanks.

shangles commented 6 years ago

A couple things to add. I just upgraded FF to v61. In my household I also have a MacBook that I use on my Firefox Sync account. I wonder if there was some strangeness going on with it syncing the unwanted, alphabetically sorted, bookmarks in the toolbar from the Mac back to my Windows machine?

Not sure. I've since logged into both computers, upgraded Firefox, reinstalled ASB v3.3 and configured them identically. So far, the toolbar has the bookmarks manually sorted where I want them. Hopefully it lasts.